Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 11856010: Change the inlining context from an enum to a class. (Closed)

Created:
7 years, 11 months ago by Kevin Millikin (Google)
Modified:
7 years, 11 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change the inlining context from an enum to a class. To support inlining in test contexts, the inlining context needs to have its dispatched behavior and state. This change introduces a context class representing calls inlined for their value or solely for their effects. The intermediate array of exits is moved from the graph to the inlining context. The implementation behavior is otherwise the same as before. Committed: https://code.google.com/p/dart/source/detail?r=16965

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -110 lines) Patch
M runtime/vm/compiler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph.h View 4 chunks +4 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph.cc View 9 chunks +26 lines, -45 lines 0 comments Download
M runtime/vm/flow_graph_builder.h View 4 chunks +49 lines, -21 lines 2 comments Download
M runtime/vm/flow_graph_builder.cc View 7 chunks +39 lines, -15 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Google)
7 years, 11 months ago (2013-01-11 11:21:22 UTC) #1
Florian Schneider
LGTM.
7 years, 11 months ago (2013-01-11 11:41:57 UTC) #2
srdjan
7 years, 11 months ago (2013-01-11 21:40:25 UTC) #3
Message was sent while issue was closed.
DBC

https://codereview.chromium.org/11856010/diff/1/runtime/vm/flow_graph_builder.h
File runtime/vm/flow_graph_builder.h (right):

https://codereview.chromium.org/11856010/diff/1/runtime/vm/flow_graph_builder...
runtime/vm/flow_graph_builder.h:44: intptr_t NumExits() { return
exits_.length(); }
const

https://codereview.chromium.org/11856010/diff/1/runtime/vm/flow_graph_builder...
runtime/vm/flow_graph_builder.h:65: InliningContext* inlining_context);
An alternative could be to pass an instance of class NotInliningContext : public
InliningContext.

Powered by Google App Engine
This is Rietveld 408576698