Change the inlining context from an enum to a class.

runtime/vm/flow_graph_builder.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_FLOW_GRAPH_BUILDER_H_
 #define VM_FLOW_GRAPH_BUILDER_H_
 
 #include "vm/allocation.h"
 #include "vm/ast.h"
 #include "vm/growable_array.h"
 #include "vm/intermediate_language.h"
 
 namespace dart {
 
 class FlowGraph;
 class Instruction;
 class ParsedFunction;
 
+// An abstraction of the graph context in which an inlined call occurs.
+class InliningContext: public ZoneAllocated {
+ public:
+  virtual void AddExit(ReturnInstr* exit) = 0;
+};
+
+
+// The context of a call inlined for its value (including calls inlined for
+// their effects, i.e., when the value is ignored).  Collects normal exit
+// blocks and return values.
+class ValueInliningContext: public InliningContext {
+ public:
+  ValueInliningContext() : exits_(4) { }
+
+  BlockEntryInstr* ExitBlockAt(intptr_t i) const {
+    ASSERT(exits_[i].exit_block != NULL);
+    return exits_[i].exit_block;
+  }
+  Instruction* LastInstructionAt(intptr_t i) const {
+    return exits_[i].exit_return->previous();
+  }
+  Value* ValueAt(intptr_t i) const {
+    return exits_[i].exit_return->value();
+  }
+
+  intptr_t NumExits() { return exits_.length(); }

[srdjan, 2013/01/11 21:40:26]

const

+  virtual void AddExit(ReturnInstr* exit);
+  void SortExits();
+
+ private:
+  struct Data {
+    BlockEntryInstr* exit_block;
+    ReturnInstr* exit_return;
+  };
+
+  static int LowestBlockIdFirst(const Data* a, const Data* b);
+
+  GrowableArray<Data> exits_;
+};
+
+
 // Build a flow graph from a parsed function's AST.
 class FlowGraphBuilder: public ValueObject {
  public:
-  explicit FlowGraphBuilder(const ParsedFunction& parsed_function);
+  // The inlining context is NULL if not inlining.
+  FlowGraphBuilder(const ParsedFunction& parsed_function,
+                   InliningContext* inlining_context);

[srdjan, 2013/01/11 21:40:26]

An alternative could be to pass an instance of class NotInliningContext : public
InliningContext.

 
-  enum InliningContext {
-    kNotInlining,
-    kValueContext,
-    kEffectContext,
-    kTestContext
-  };
-
-  FlowGraph* BuildGraph(InliningContext context, intptr_t initial_loop_depth);
+  FlowGraph* BuildGraph(intptr_t initial_loop_depth);
 
   const ParsedFunction& parsed_function() const { return parsed_function_; }
 
   void Bailout(const char* reason);
 
   intptr_t AllocateBlockId() { return ++last_used_block_id_; }
   void SetInitialBlockId(intptr_t id) { last_used_block_id_ = id; }
 
   void set_context_level(intptr_t value) { context_level_ = value; }
   intptr_t context_level() const { return context_level_; }
@@ skipping 10 matching lines @@
   intptr_t num_copied_params() const {
     return num_copied_params_;
   }
   intptr_t num_non_copied_params() const {
     return num_non_copied_params_;
   }
   intptr_t num_stack_locals() const {
     return num_stack_locals_;
   }
 
-  bool InInliningContext() const { return inlining_context_ != kNotInlining; }
-  void AddReturnExit(ReturnInstr* return_instr) {
-    if (InInliningContext()) {
-      ASSERT(exits_ != NULL);
-      exits_->Add(return_instr);
-    }
-  }
+  bool InInliningContext() const { return (inlining_context_ != NULL); }
+  InliningContext* inlining_context() const { return inlining_context_; }
 
  private:
   intptr_t parameter_count() const {
     return num_copied_params_ + num_non_copied_params_;
   }
   intptr_t variable_count() const {
     return parameter_count() + num_stack_locals_;
   }
 
   const ParsedFunction& parsed_function_;
 
   const intptr_t num_copied_params_;
   const intptr_t num_non_copied_params_;
   const intptr_t num_stack_locals_;  // Does not include any parameters.
+  InliningContext* const inlining_context_;
 
   intptr_t last_used_block_id_;
   intptr_t context_level_;
   intptr_t last_used_try_index_;
   intptr_t try_index_;
   GraphEntryInstr* graph_entry_;
-  InliningContext inlining_context_;
-  ZoneGrowableArray<ReturnInstr*>* exits_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(FlowGraphBuilder);
 };
 
 
 class TestGraphVisitor;
 
 // Translate an AstNode to a control-flow graph fragment for its effects
 // (e.g., a statement or an expression in an effect context).  Implements a
 // function from an AstNode and next temporary index to a graph fragment
@@ skipping 55 matching lines @@
   void TieLoop(const TestGraphVisitor& test_fragment,
                const EffectGraphVisitor& body_fragment);
 
   // Wraps a value in a push-argument instruction and adds the result to the
   // graph.
   PushArgumentInstr* PushArgument(Value* value);
 
   // This implementation shares state among visitors by using the builder.
   // The implementation is incorrect if a visitor that hits a return is not
   // actually added to the graph.
-  void AddReturnExit(ReturnInstr* return_instr) {
-    owner()->AddReturnExit(return_instr);
-  }
+  void AddReturnExit(intptr_t token_pos, Value* value);
 
  protected:
   Definition* BuildStoreTemp(const LocalVariable& local, Value* value);
   Definition* BuildStoreExprTemp(Value* value);
   Definition* BuildLoadExprTemp();
 
   Definition* BuildStoreLocal(const LocalVariable& local,
                               Value* value,
                               bool result_is_needed);
   Definition* BuildLoadLocal(const LocalVariable& local);
@@ skipping 238 matching lines @@
   // Output parameters.
   GrowableArray<TargetEntryInstr**> true_successor_addresses_;
   GrowableArray<TargetEntryInstr**> false_successor_addresses_;
 
   intptr_t condition_token_pos_;
 };
 
 }  // namespace dart
 
 #endif  // VM_FLOW_GRAPH_BUILDER_H_