Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1182673002: Add an assertion to ensure that the return type and types of parameters are canonical or a TypeParam (Closed)

Created:
5 years, 6 months ago by siva
Modified:
5 years, 6 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add an assertion to ensure that the return type and types of parameters are canonical or a TypeParameter. BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/298a2f467f2eddee748825c5d25a98e4c601e135

Patch Set 1 #

Patch Set 2 : address self review comments. #

Total comments: 6

Patch Set 3 : address code review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -8 lines) Patch
M runtime/bin/gen_snapshot.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/compiler.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 2 chunks +46 lines, -0 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 1 7 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
siva
5 years, 6 months ago (2015-06-11 23:37:34 UTC) #2
regis
lgtm with comments https://codereview.chromium.org/1182673002/diff/20001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/1182673002/diff/20001/runtime/vm/dart_api_impl.cc#newcode76 runtime/vm/dart_api_impl.cc:76: // or not. If they are ...
5 years, 6 months ago (2015-06-11 23:53:40 UTC) #3
siva
https://codereview.chromium.org/1182673002/diff/20001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/1182673002/diff/20001/runtime/vm/dart_api_impl.cc#newcode76 runtime/vm/dart_api_impl.cc:76: // or not. If they are not canonicalized if ...
5 years, 6 months ago (2015-06-12 00:23:15 UTC) #4
regis
lgtm even more.
5 years, 6 months ago (2015-06-12 00:27:33 UTC) #5
siva
5 years, 6 months ago (2015-06-12 01:09:45 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
298a2f467f2eddee748825c5d25a98e4c601e135 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698