Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Unified Diff: runtime/bin/gen_snapshot.cc

Issue 1182673002: Add an assertion to ensure that the return type and types of parameters are canonical or a TypeParam (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address code review comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/class_finalizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/gen_snapshot.cc
diff --git a/runtime/bin/gen_snapshot.cc b/runtime/bin/gen_snapshot.cc
index 1aaf1925f6938b114e18148b9957d189cde1440c..9ce1b2c44732ec461eef87e25ee5212a727c7caf 100644
--- a/runtime/bin/gen_snapshot.cc
+++ b/runtime/bin/gen_snapshot.cc
@@ -516,7 +516,7 @@ static void SetupForGenericSnapshotCreation() {
int main(int argc, char** argv) {
- const int EXTRA_VM_ARGUMENTS = 1;
+ const int EXTRA_VM_ARGUMENTS = 2;
CommandLineOptions vm_options(argc + EXTRA_VM_ARGUMENTS);
// Initialize the URL mapping array.
@@ -536,7 +536,9 @@ int main(int argc, char** argv) {
DartUtils::SetOriginalWorkingDirectory();
vm_options.AddArgument("--load_deferred_eagerly");
-
+ // Workaround until issue 21620 is fixed.
+ // (https://github.com/dart-lang/sdk/issues/21620)
+ vm_options.AddArgument("--no-concurrent_sweep");
Dart_SetVMFlags(vm_options.count(), vm_options.arguments());
// Initialize the Dart VM.
« no previous file with comments | « no previous file | runtime/vm/class_finalizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698