Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1182613004: Fix reflective NoSuchMethodErrors to match their non-reflective counter parts when due to argument … (Closed)

Created:
5 years, 6 months ago by rmacnak
Modified:
5 years, 6 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix reflective NoSuchMethodErrors to match their non-reflective counterparts when due to argument mismatches. BUG=http://dartbug.com/23266 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/98b9ff6a30809d771f74fa482e83b64de33ab00a

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -25 lines) Patch
M runtime/lib/mirrors.cc View 1 13 chunks +37 lines, -22 lines 0 comments Download
M tests/lib/lib.status View 1 2 chunks +2 lines, -0 lines 0 comments Download
A tests/lib/mirrors/mirrors_nsm_mismatch_test.dart View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
M tests/lib/mirrors/mirrors_nsm_test.dart View 3 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 6 months ago (2015-06-15 23:03:18 UTC) #2
siva
lgtm
5 years, 6 months ago (2015-06-16 15:45:13 UTC) #3
rmacnak
5 years, 6 months ago (2015-06-16 16:42:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
98b9ff6a30809d771f74fa482e83b64de33ab00a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698