Clean up uses of X::CheckedHandle where X::Cast or X::Handle is sufficient.

Cleanup uses of X::CheckedHandle where X::Cast or X::Handle is sufficient.

The only places where CheckedHandle is appropiate is with arguments to
runtime functions and values from Dart API functions.

For other places in the VM either normal Handle and ^=, or Cast is sufficient.

T::Cast is used when the value is guaranteed to be of type T (and never Object::null()).
Otherwise, the operator^= is used for casting.

Also fix a style issue where a Raw* should be used as return type.
Committed: https://code.google.com/p/dart/source/detail?r=17013

[Florian Schneider, 2013-01-09 15:05:29]

On 2013/01/09 12:02:05, Florian Schneider wrote:

Please disregard it for now. I need to treat the places where null can occur
accordingly.

[Florian Schneider, 2013-01-10 09:58:30]

New patch set uploaded. Please have a look:

* Use ^= to cast where Object::null() may occur. If the type is guaranteed by a
Is#T test, T::Cast can be used.

+1 style fix: return Raw-pointer instead of handle in one function.

[Ivan Posva, 2013-01-11 23:13:33]

LGTMwC.

-Ivan

https://codereview.chromium.org/11826024/diff/6001/runtime/vm/disassembler_ia...
File runtime/vm/disassembler_ia32.cc (right):

https://codereview.chromium.org/11826024/diff/6001/runtime/vm/disassembler_ia...
runtime/vm/disassembler_ia32.cc:435: arr ^= obj.raw();
const Array& arr = Array::Cast(obj);

https://codereview.chromium.org/11826024/diff/6001/runtime/vm/disassembler_x6...
File runtime/vm/disassembler_x64.cc (right):

https://codereview.chromium.org/11826024/diff/6001/runtime/vm/disassembler_x6...
runtime/vm/disassembler_x64.cc:814: Array& arr = Array::Handle();
ditto

[Florian Schneider, 2013-01-14 09:43:57]

Thanks. Landing.

https://codereview.chromium.org/11826024/diff/6001/runtime/vm/disassembler_ia...
File runtime/vm/disassembler_ia32.cc (right):

https://codereview.chromium.org/11826024/diff/6001/runtime/vm/disassembler_ia...
runtime/vm/disassembler_ia32.cc:435: arr ^= obj.raw();
On 2013/01/11 23:13:33, Ivan Posva wrote:
> const Array& arr = Array::Cast(obj);

Done.

https://codereview.chromium.org/11826024/diff/6001/runtime/vm/disassembler_x6...
File runtime/vm/disassembler_x64.cc (right):

https://codereview.chromium.org/11826024/diff/6001/runtime/vm/disassembler_x6...
runtime/vm/disassembler_x64.cc:814: Array& arr = Array::Handle();
On 2013/01/11 23:13:33, Ivan Posva wrote:
> ditto

Done.