Clean up uses of X::CheckedHandle where X::Cast or X::Handle is sufficient.

runtime/vm/disassembler_x64.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/disassembler.h"
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_X64)
 #include "platform/utils.h"
 #include "vm/allocation.h"
@@ skipping 773 matching lines @@
       obj.IsString() ||
       obj.IsNull() ||
       obj.IsBool() ||
       obj.IsClass() ||
       obj.IsFunction() ||
       obj.IsICData() ||
       obj.IsField()) {
     return obj.ToCString();
   }
 
-  const Class& clazz = Class::CheckedHandle(obj.clazz());
+  const Class& clazz = Class::Handle(obj.clazz());
   const char* full_class_name = clazz.ToCString();
   const char* format = "instance of %s";
   intptr_t len = OS::SNPrint(NULL, 0, format, full_class_name) + 1;
   char* chars = Isolate::Current()->current_zone()->Alloc<char>(len);
   OS::SNPrint(chars, len, format, full_class_name);
   return chars;
 }
 
 
 void DisassemblerX64::AppendAddressToBuffer(uint8_t* addr_byte_ptr) {
   NoGCScope no_gc;
   uword addr = reinterpret_cast<uword>(addr_byte_ptr);
   AppendToBuffer("%#"Px"", addr);
   // Try to print as heap object or stub name
   if (((addr & kSmiTagMask) == kHeapObjectTag) &&
       !Isolate::Current()->heap()->CodeContains(addr) &&
       Isolate::Current()->heap()->Contains(addr - kHeapObjectTag)) {
-    Object& obj = Object::Handle(reinterpret_cast<RawObject*>(addr));
+    const Object& obj = Object::Handle(reinterpret_cast<RawObject*>(addr));
     if (obj.IsArray()) {
-      const Array& arr = Array::CheckedHandle(obj.raw());
+      const Array& arr = Array::Cast(obj);
       intptr_t len = arr.Length();
       if (len > 5) len = 5;  // Print a max of 5 elements.
       AppendToBuffer("  Array[");
       int i = 0;
+      Object& element = Object::Handle();
       while (i < len) {
-        obj = arr.At(i);
+        element = arr.At(i);
         if (i > 0) AppendToBuffer(", ");
-        AppendToBuffer("%s", ObjectToCStringNoGC(obj));
+        AppendToBuffer("%s", ObjectToCStringNoGC(element));
         i++;
       }
       if (i < arr.Length()) AppendToBuffer(", ...");
       AppendToBuffer("]");
       return;
     }
     AppendToBuffer("  '%s'", ObjectToCStringNoGC(obj));
   } else {
     // 'addr' is not an object, but probably a code address.
     const char* name_of_stub = StubCode::NameOfStub(addr);
@@ skipping 1010 matching lines @@
                                const Code::Comments& comments) {
   ASSERT(formatter != NULL);
   char hex_buffer[kHexadecimalBufferSize];  // Instruction in hexadecimal form.
   char human_buffer[kUserReadableBufferSize];  // Human-readable instruction.
   uword pc = start;
   intptr_t comment_finger = 0;
   while (pc < end) {
     const intptr_t offset = pc - start;
     while (comment_finger < comments.Length() &&
            comments.PCOffsetAt(comment_finger) <= offset) {
-      formatter->Print("        ;; %s\n",
-                       comments.CommentAt(comment_finger).ToCString());
+      formatter->Print(
+          "        ;; %s\n",
+          String::Handle(comments.CommentAt(comment_finger)).ToCString());
       comment_finger++;
     }
     int instruction_length = DecodeInstruction(hex_buffer,
                                                sizeof(hex_buffer),
                                                human_buffer,
                                                sizeof(human_buffer),
                                                pc);
     formatter->ConsumeInstruction(hex_buffer,
                                   sizeof(hex_buffer),
                                   human_buffer,
                                   sizeof(human_buffer),
                                   pc);
     pc += instruction_length;
   }
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_X64