Issue 1182423003: Revert "Clean up process spawning."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1182423003: Revert "Clean up process spawning." (Closed)

Created:
5 years, 6 months ago by Anders Johnsen

Modified:
5 years, 6 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Revert "Clean up process spawning." This reverts commits - bbdc57ebf6a5f0a2646c88ce3c42ff866ab97599 - bd25e641f2819f6d353f712f3831eec767f37be6 - 5cc8fca131c00d5b673665af6dfc7f4906b1186d - ed72caa3cd17f3762a1f018b048714612ccf8de3 BUG= Committed: https://github.com/dart-lang/sdk/commit/9a01a22e96db9f407b729007f524e6e1e422ae51

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+124 lines, -80 lines)			Patch
M	runtime/bin/process_android.cc	View	9 chunks	+36 lines, -26 lines	0 comments	Download
M	runtime/bin/process_linux.cc	View	9 chunks	+36 lines, -26 lines	0 comments	Download
M	runtime/bin/process_macos.cc	View	8 chunks	+37 lines, -21 lines	0 comments	Download
M	tests/standalone/io/platform_resolved_executable_test.dart	View	2 chunks	+15 lines, -6 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Anders Johnsen

Committed patchset #1 (id:1) manually as 9a01a22e96db9f407b729007f524e6e1e422ae51 (presubmit successful).

5 years, 6 months ago (2015-06-15 13:27:01 UTC) #3

Søren Gjesse

5 years, 6 months ago (2015-06-15 14:20:43 UTC) #4

Message was sent while issue was closed.

What was the reason?

I just filed https://github.com/dart-lang/sdk/issues/23639, including these four
changes so I guess they should be reverted on dev then?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages