Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: tests/standalone/io/platform_resolved_executable_test.dart

Issue 1182423003: Revert "Clean up process spawning." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/bin/process_macos.cc ('k') | tests/standalone/standalone.status » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // 4 //
5 // Process test program to test process communication. 5 // Process test program to test process communication.
6 6
7 library PlatformExecutableTest; 7 library PlatformExecutableTest;
8 8
9 import "dart:io"; 9 import "dart:io";
10 10
(...skipping 25 matching lines...) Expand all
36 36
37 var result = processResult.stdout.trim(); 37 var result = processResult.stdout.trim();
38 expectEquals(Platform.resolvedExecutable, result); 38 expectEquals(Platform.resolvedExecutable, result);
39 } 39 }
40 40
41 void testDartExecShouldNotBeInCurrentDir() { 41 void testDartExecShouldNotBeInCurrentDir() {
42 var type = FileSystemEntity.typeSync(platformExeName); 42 var type = FileSystemEntity.typeSync(platformExeName);
43 expectEquals(FileSystemEntityType.NOT_FOUND, type); 43 expectEquals(FileSystemEntityType.NOT_FOUND, type);
44 } 44 }
45 45
46 void testShouldSucceedWithEmptyPathEnvironment() { 46 void testShouldFailOutsidePath() {
47 var command = Platform.isWindows ? 'cmd' : 'ls'; 47 var threw = false;
48 Process.runSync(command, [], 48 try {
49 includeParentEnvironment: false, 49 Process.runSync(platformExeName, ['--version'],
50 environment: {_SCRIPT_KEY: 'yes', 'PATH': ''}); 50 includeParentEnvironment: false,
51 environment: {_SCRIPT_KEY: 'yes', 'PATH': ''});
52 } catch (_) {
53 threw = true;
54 }
55
56 if (!threw) {
57 throw 'Expected running the dart executable – "$platformExeName" without'
58 ' the parent environment or path to fail.';
59 }
51 } 60 }
52 61
53 void testShouldSucceedWithSourcePlatformExecutable() { 62 void testShouldSucceedWithSourcePlatformExecutable() {
54 verify(Platform.resolvedExecutable); 63 verify(Platform.resolvedExecutable);
55 } 64 }
56 65
57 void testExeSymLinked(Directory dir) { 66 void testExeSymLinked(Directory dir) {
58 var dirUri = new Uri.directory(dir.path); 67 var dirUri = new Uri.directory(dir.path);
59 var link = new Link.fromUri(dirUri.resolve('dart_exe_link')); 68 var link = new Link.fromUri(dirUri.resolve('dart_exe_link'));
60 link.createSync(Platform.resolvedExecutable); 69 link.createSync(Platform.resolvedExecutable);
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 if (!Platform.isWindows) { 146 if (!Platform.isWindows) {
138 withTempDir(testExeSymLinked); /// 01: ok 147 withTempDir(testExeSymLinked); /// 01: ok
139 } 148 }
140 withTempDir(testExeDirSymLinked); /// 02: ok 149 withTempDir(testExeDirSymLinked); /// 02: ok
141 testPathToSDKDir(); /// 03: ok 150 testPathToSDKDir(); /// 03: ok
142 withTempDir(testPathPointsToSymLinkedSDKPath); /// 04: ok 151 withTempDir(testPathPointsToSymLinkedSDKPath); /// 04: ok
143 // dart:io does not support linking to files in Windows. 152 // dart:io does not support linking to files in Windows.
144 if (!Platform.isWindows) { 153 if (!Platform.isWindows) {
145 withTempDir(testPathToDirWithExeSymLinked); /// 05: ok 154 withTempDir(testPathToDirWithExeSymLinked); /// 05: ok
146 } 155 }
147 testShouldSucceedWithEmptyPathEnvironment(); /// 06: ok 156 testShouldFailOutsidePath(); /// 06: ok
148 } 157 }
OLDNEW
« no previous file with comments | « runtime/bin/process_macos.cc ('k') | tests/standalone/standalone.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698