Issue 11824028: Add a hashCode to Command so reporting timings is 400 faster.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11824028: Add a hashCode to Command so reporting timings is 400 faster. (Closed)

Created:
7 years, 11 months ago by ahe

Modified:
7 years, 11 months ago

Reviewers:
ricow1, kustermann

CC:
reviews_dartlang.org, Ivan Posva

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add a hashCode to Command so reporting timings is 400 faster. Committed: https://code.google.com/p/dart/source/detail?r=16859

Patch Set 2 : Add operator== #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	dart/tools/testing/dart/test_runner.dart	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kustermann

Sort of LGTM ;-) https://codereview.chromium.org/11824028/diff/1/dart/tools/testing/dart/test_runner.dart File dart/tools/testing/dart/test_runner.dart (right): https://codereview.chromium.org/11824028/diff/1/dart/tools/testing/dart/test_runner.dart#newcode81 dart/tools/testing/dart/test_runner.dart:81: You could add an '==' ...

7 years, 11 months ago (2013-01-09 15:30:12 UTC) #2

ahe

7 years, 11 months ago (2013-01-09 15:38:01 UTC) #3

Good idea, thanks.

https://codereview.chromium.org/11824028/diff/1/dart/tools/testing/dart/test_...
File dart/tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/11824028/diff/1/dart/tools/testing/dart/test_...
dart/tools/testing/dart/test_runner.dart:81: 
On 2013/01/09 15:30:12, kustermann wrote:
> You could add an '==' operator here as well.

Done.

Expand Messages | Collapse Messages

Issue 11824028: Add a hashCode to Command so reporting timings is 400 faster. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add operator== #

Messages