Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: dart/tools/testing/dart/test_runner.dart

Issue 11824028: Add a hashCode to Command so reporting timings is 400 faster. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 if (found) { 69 if (found) {
70 return i; 70 return i;
71 } 71 }
72 } 72 }
73 return -1; 73 return -1;
74 } 74 }
75 75
76 76
77 /** A command executed as a step in a test case. */ 77 /** A command executed as a step in a test case. */
78 class Command { 78 class Command {
79 static int nextHashCode = 0;
80 final int hashCode = nextHashCode++;
81
kustermann 2013/01/09 15:30:12 You could add an '==' operator here as well.
ahe 2013/01/09 15:38:02 Done.
79 /** Path to the executable of this command. */ 82 /** Path to the executable of this command. */
80 String executable; 83 String executable;
81 84
82 /** Command line arguments to the executable. */ 85 /** Command line arguments to the executable. */
83 List<String> arguments; 86 List<String> arguments;
84 87
85 /** Environment for the command */ 88 /** Environment for the command */
86 Map<String,String> environment; 89 Map<String,String> environment;
87 90
88 /** The actual command line that will be executed. */ 91 /** The actual command line that will be executed. */
(...skipping 1649 matching lines...) Expand 10 before | Expand all | Expand 10 after
1738 // the developer doesn't waste his or her time trying to fix a bunch of 1741 // the developer doesn't waste his or her time trying to fix a bunch of
1739 // tests that appear to be broken but were actually just flakes that 1742 // tests that appear to be broken but were actually just flakes that
1740 // didn't get retried because there had already been one failure. 1743 // didn't get retried because there had already been one failure.
1741 bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests; 1744 bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
1742 new RunningProcess(test, allowRetry, this).start(); 1745 new RunningProcess(test, allowRetry, this).start();
1743 } 1746 }
1744 _numProcesses++; 1747 _numProcesses++;
1745 } 1748 }
1746 } 1749 }
1747 } 1750 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698