Issue 11823067: Fixed warnings reported by clang compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11823067: Fixed warnings reported by clang compiler. (Closed)

Created:
7 years, 11 months ago by Tom Ball

Modified:
7 years, 11 months ago

Reviewers:
Kevin Millikin (Google), siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fixed warnings reported by clang compiler. Committed: https://code.google.com/p/dart/source/detail?r=16982

Patch Set 1 #

Total comments: 2

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	runtime/third_party/jscre/pcre_internal.h	View		1 chunk	+2 lines, -2 lines	1 comment	Download
	M	runtime/vm/os.h	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

https://codereview.chromium.org/11823067/diff/1/runtime/third_party/jscre/pcre_internal.h File runtime/third_party/jscre/pcre_internal.h (right): https://codereview.chromium.org/11823067/diff/1/runtime/third_party/jscre/pcre_internal.h#newcode86 runtime/third_party/jscre/pcre_internal.h:86: #define ASSERT(x) if (!(x)) *(reinterpret_cast<volatile int*>(NULL)) = NULL Drive ...

7 years, 11 months ago (2013-01-11 11:30:59 UTC) #2

siva

7 years, 11 months ago (2013-01-11 18:02:25 UTC) #3

lgtm

https://codereview.chromium.org/11823067/diff/1/runtime/vm/os.h
File runtime/vm/os.h (right):

https://codereview.chromium.org/11823067/diff/1/runtime/vm/os.h#newcode11
runtime/vm/os.h:11: struct tm;
We don't seem to use 'tm' anywhere in this file. We could probably get rid of
it.

Expand Messages | Collapse Messages