runtime/third_party/jscre/pcre_internal.h - Issue 11823067: Fixed warnings reported by clang compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/third_party/jscre/pcre_internal.h

Issue 11823067: Fixed warnings reported by clang compiler. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/third_party/jscre/pcre_internal.h

===================================================================

--- runtime/third_party/jscre/pcre_internal.h (revision 16936)

+++ runtime/third_party/jscre/pcre_internal.h (working copy)

@@ -83,8 +83,8 @@

#ifndef DFTABLES

// TODO(xxx): Hook this up to something that checks assertions.

-#define ASSERT(x) if (!(x)) *(reinterpret_cast<int*>(NULL)) = NULL

-#define ASSERT_NOT_REACHED() *(reinterpret_cast<int*>(NULL)) = NULL

+#define ASSERT(x) if (!(x)) *(reinterpret_cast<volatile int*>(NULL)) = NULL

Kevin Millikin (Google) 2013/01/11 11:30:59 Drive by: shouldn't this be fixed upstream in WebK

+#define ASSERT_NOT_REACHED() *(reinterpret_cast<volatile int*>(NULL)) = NULL

#ifdef WIN32

#pragma warning(disable: 4232)

« no previous file with comments | « no previous file | runtime/vm/os.h » ('j') | runtime/vm/os.h » ('J')