Issue 11821012: Get more pub tests working.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11821012: Get more pub tests working. (Closed)

Created:
7 years, 11 months ago by Bob Nystrom

Modified:
7 years, 11 months ago

Reviewers:
nweiz, floitsch

CC:
reviews_dartlang.org, floitsch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Get more pub tests working. Committed: https://code.google.com/p/dart/source/detail?r=16830

Patch Set 1 #

Total comments: 2

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -16 lines)			Patch
M	sdk/lib/async/future.dart	View	1 chunk	+2 lines, -2 lines	2 comments	Download
M	utils/pub/io.dart	View	7 chunks	+10 lines, -7 lines	0 comments	Download
M	utils/pub/oauth2.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/utils.dart	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	utils/tests/pub/test_pub.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/11821012/diff/1/sdk/lib/async/future.dart File sdk/lib/async/future.dart (right): https://codereview.chromium.org/11821012/diff/1/sdk/lib/async/future.dart#newcode137 sdk/lib/async/future.dart:137: * completer.completeError(error); You may want to at least ...

7 years, 11 months ago (2013-01-09 01:24:07 UTC) #2

Bob Nystrom

Thanks! https://codereview.chromium.org/11821012/diff/1/sdk/lib/async/future.dart File sdk/lib/async/future.dart (right): https://codereview.chromium.org/11821012/diff/1/sdk/lib/async/future.dart#newcode137 sdk/lib/async/future.dart:137: * completer.completeError(error); On 2013/01/09 01:24:07, nweiz wrote: > ...

7 years, 11 months ago (2013-01-09 01:31:35 UTC) #3

Message was sent while issue was closed.

LGTM.

Expand Messages | Collapse Messages