Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: utils/tests/pub/test_pub.dart

Issue 11821012: Get more pub tests working. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sdk/lib/async/future.dart ('K') | « utils/pub/utils.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/test_pub.dart
diff --git a/utils/tests/pub/test_pub.dart b/utils/tests/pub/test_pub.dart
index 6fe24b5ed93e902cdfededb038587572b2919a73..9d2b6085f8c25eb798613e71178493d330607b80 100644
--- a/utils/tests/pub/test_pub.dart
+++ b/utils/tests/pub/test_pub.dart
@@ -834,9 +834,9 @@ abstract class Descriptor {
var error = new StringBuffer();
error.add("No files named $name in $dir were valid:\n");
for (var failure in failures) {
- error.add(" ").add(failure).add("\n");
+ error.add(" $failure\n");
}
- completer.completeException(
+ completer.completeError(
new ExpectException(error.toString()), stackTrace);
}
@@ -851,7 +851,7 @@ abstract class Descriptor {
future.then((_) {
successes++;
checkComplete();
- }).catchError(() {});
+ }).catchError((_) {});
}
return completer.future;
});
« sdk/lib/async/future.dart ('K') | « utils/pub/utils.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698