Revert change to Platform.excutable and add Platform.resolvedExecutable

Revert change to Platform.excutable and add Platform.resolvedExecutable

The change to Platform.excutable in
e03ab1743717c39099a9161999e231699098a811 was a breaking change and it
has been reverted.

A new getter Platform.resolvedExecutable has been added to provide the
the fully qualified path of the executable.

BUG=https://github.com/dart-lang/sdk/issues/16994
R=lrn@google.com, kustermann@google.com, len@google.com

Committed: https://github.com/dart-lang/sdk/commit/c05c8c66069db91cc2fd48691dfc406c818d411d

[kustermann, 2015-06-12 11:05:35]

kustermann@google.com changed reviewers:
+ lrn@google.com
- len@google.com

[kustermann, 2015-06-12 11:05:35]

Removing len@ - whoever that is - and adding lrn@ :)

[Lasse Reichstein Nielsen, 2015-06-12 14:12:17]

Is there any way to run tests on a platform that doesn't support resolving the
execuable name?

Otherwise, don't documnet that there is an option to not resolve it, just
require the system to do so.

https://codereview.chromium.org/1180623006/diff/1/sdk/lib/io/platform.dart
File sdk/lib/io/platform.dart (right):

https://codereview.chromium.org/1180623006/diff/1/sdk/lib/io/platform.dart#ne...
sdk/lib/io/platform.dart:150: * This is the absolute path with all symlinks
resolved to the
commas around "with all symlinks resolved".

https://codereview.chromium.org/1180623006/diff/1/sdk/lib/io/platform.dart#ne...
sdk/lib/io/platform.dart:151: * executable used to running the script.
running -> run

https://codereview.chromium.org/1180623006/diff/1/sdk/lib/io/platform.dart#ne...
sdk/lib/io/platform.dart:154: * [resolvedExecutable] an empty string is
returned.
comma before "an". Or rewrite as:
Returns an empty string if ...

Why not throw? It's not like the caller can use an empty string for anything.

https://codereview.chromium.org/1180623006/diff/1/tests/standalone/io/platfor...
File tests/standalone/io/platform_executable_test.dart (right):

https://codereview.chromium.org/1180623006/diff/1/tests/standalone/io/platfor...
tests/standalone/io/platform_executable_test.dart:125: if
(Platform.environment.containsKey(_SCRIPT_KEY)) {
Docment this. What is _SCRIPT_KEY? What does it mean?

https://codereview.chromium.org/1180623006/diff/1/tests/standalone/io/platfor...
File tests/standalone/io/platform_test.dart (right):

https://codereview.chromium.org/1180623006/diff/1/tests/standalone/io/platfor...
tests/standalone/io/platform_test.dart:28:
Expect.isTrue(Platform.resolvedExecutable.contains('dart'));
This is making a lot of assumptions. A *lot* - like knowing all OS'es and that
the dart executable is called dart (or is located in a directory named dart,
which would also satisfy this test).

[Lasse Reichstein Nielsen, 2015-06-12 14:13:31]

https://codereview.chromium.org/1180623006/diff/1/sdk/lib/io/platform.dart
File sdk/lib/io/platform.dart (right):

https://codereview.chromium.org/1180623006/diff/1/sdk/lib/io/platform.dart#ne...
sdk/lib/io/platform.dart:154: * [resolvedExecutable] an empty string is
returned.

> Why not throw? It's not like the caller can use an empty string for anything.

And if throw, why give an option to not support it at all. Any implementation
can choose to throw UnsupportedError anyway.

[Søren Gjesse, 2015-06-15 07:28:15]

PTAL

(I hope it works on Windows)

https://codereview.chromium.org/1180623006/diff/1/sdk/lib/io/platform.dart
File sdk/lib/io/platform.dart (right):

https://codereview.chromium.org/1180623006/diff/1/sdk/lib/io/platform.dart#ne...
sdk/lib/io/platform.dart:150: * This is the absolute path with all symlinks
resolved to the
On 2015/06/12 14:12:17, Lasse Reichstein Nielsen wrote:
> commas around "with all symlinks resolved".

Done.

https://codereview.chromium.org/1180623006/diff/1/sdk/lib/io/platform.dart#ne...
sdk/lib/io/platform.dart:151: * executable used to running the script.
On 2015/06/12 14:12:17, Lasse Reichstein Nielsen wrote:
> running -> run

Done.

https://codereview.chromium.org/1180623006/diff/1/sdk/lib/io/platform.dart#ne...
sdk/lib/io/platform.dart:154: * [resolvedExecutable] an empty string is
returned.
On 2015/06/12 14:13:31, Lasse Reichstein Nielsen wrote:
> 
> > Why not throw? It's not like the caller can use an empty string for
anything.
> 
> And if throw, why give an option to not support it at all. Any implementation
> can choose to throw UnsupportedError anyway.

Good point. Removed this option. All current platforms support it.

https://codereview.chromium.org/1180623006/diff/1/sdk/lib/io/platform.dart#ne...
sdk/lib/io/platform.dart:154: * [resolvedExecutable] an empty string is
returned.
On 2015/06/12 14:12:17, Lasse Reichstein Nielsen wrote:
> comma before "an". Or rewrite as:
> Returns an empty string if ...
> 
> Why not throw? It's not like the caller can use an empty string for anything.

See below.

https://codereview.chromium.org/1180623006/diff/1/tests/standalone/io/platfor...
File tests/standalone/io/platform_executable_test.dart (right):

https://codereview.chromium.org/1180623006/diff/1/tests/standalone/io/platfor...
tests/standalone/io/platform_executable_test.dart:125: if
(Platform.environment.containsKey(_SCRIPT_KEY)) {
On 2015/06/12 14:12:17, Lasse Reichstein Nielsen wrote:
> Docment this. What is _SCRIPT_KEY? What does it mean?

Done.

https://codereview.chromium.org/1180623006/diff/1/tests/standalone/io/platfor...
File tests/standalone/io/platform_test.dart (right):

https://codereview.chromium.org/1180623006/diff/1/tests/standalone/io/platfor...
tests/standalone/io/platform_test.dart:28:
Expect.isTrue(Platform.resolvedExecutable.contains('dart'));
On 2015/06/12 14:12:17, Lasse Reichstein Nielsen wrote:
> This is making a lot of assumptions. A *lot* - like knowing all OS'es and that
> the dart executable is called dart (or is located in a directory named dart,
> which would also satisfy this test).
> 

Sure this is not testing that much. Changed it a bit. When the tests are run we
control the name of the dart executable.

[Lasse Reichstein Nielsen, 2015-06-15 07:52:08]

lgtm

https://codereview.chromium.org/1180623006/diff/20001/tests/standalone/io/pla...
File tests/standalone/io/platform_executable_test.dart (right):

https://codereview.chromium.org/1180623006/diff/20001/tests/standalone/io/pla...
tests/standalone/io/platform_executable_test.dart:1: // Copyright (c) 2012, the
Dart project authors.  Please see the AUTHORS file
Maybe rename test to platform_resolved_executable_test.dart

[Søren Gjesse, 2015-06-15 08:13:30]

Committed patchset #4 (id:60001) manually as
c05c8c66069db91cc2fd48691dfc406c818d411d (presubmit successful).

[Søren Gjesse, 2015-06-15 09:49:40]

https://codereview.chromium.org/1180623006/diff/20001/tests/standalone/io/pla...
File tests/standalone/io/platform_executable_test.dart (right):

https://codereview.chromium.org/1180623006/diff/20001/tests/standalone/io/pla...
tests/standalone/io/platform_executable_test.dart:1: // Copyright (c) 2012, the
Dart project authors.  Please see the AUTHORS file
On 2015/06/15 07:52:08, Lasse Reichstein Nielsen wrote:
> Maybe rename test to platform_resolved_executable_test.dart

Done.

[kevmoo, 2015-06-23 20:41:16]

On 2015/06/15 09:49:40, Søren Gjesse wrote:
>
https://codereview.chromium.org/1180623006/diff/20001/tests/standalone/io/pla...
> File tests/standalone/io/platform_executable_test.dart (right):
> 
>
https://codereview.chromium.org/1180623006/diff/20001/tests/standalone/io/pla...
> tests/standalone/io/platform_executable_test.dart:1: // Copyright (c) 2012,
the
> Dart project authors.  Please see the AUTHORS file
> On 2015/06/15 07:52:08, Lasse Reichstein Nielsen wrote:
> > Maybe rename test to platform_resolved_executable_test.dart
> 
> Done.

In the future, please update CHANGELOG.md w/ API changes.