Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Unified Diff: tests/standalone/io/platform_test.dart

Issue 1180623006: Revert change to Platform.excutable and add Platform.resolvedExecutable (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated dart2js io_patch.dart Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/platform_resolved_executable_test.dart ('k') | tests/standalone/standalone.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/platform_test.dart
diff --git a/tests/standalone/io/platform_test.dart b/tests/standalone/io/platform_test.dart
index 269a4871a4e3a4b884e46c3e3fca89790c5940f9..00cdee9de21fffb991976cfb1b23580ee8c24922 100644
--- a/tests/standalone/io/platform_test.dart
+++ b/tests/standalone/io/platform_test.dart
@@ -24,9 +24,15 @@ test() {
Expect.isTrue(hostname is String && hostname != "");
var environment = Platform.environment;
Expect.isTrue(environment is Map<String, String>);
- Expect.isTrue(Platform.executable.contains('dart'));
if (!Platform.isWindows) {
- Expect.isTrue(Platform.executable.startsWith('/'));
+ Expect.isTrue(Platform.executable.endsWith('dart'));
+ Expect.isTrue(Platform.resolvedExecutable.endsWith('dart'));
+ } else {
+ Expect.isTrue(Platform.executable.endsWith('dart.exe'));
+ Expect.isTrue(Platform.resolvedExecutable.endsWith('dart.exe'));
+ }
+ if (!Platform.isWindows) {
+ Expect.isTrue(Platform.resolvedExecutable.startsWith('/'));
} else {
// This assumes that tests (both locally and on the bots) are
// running off a location referred to by a drive letter. If a UNC
« no previous file with comments | « tests/standalone/io/platform_resolved_executable_test.dart ('k') | tests/standalone/standalone.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698