Issue 11801008: Fix tests for VM in checked mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11801008: Fix tests for VM in checked mode. (Closed)

Created:
7 years, 11 months ago by Anders Johnsen

Modified:
7 years, 11 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix tests for VM in checked mode. BUG= Committed: https://code.google.com/p/dart/source/detail?r=16689

Patch Set 2 : Add missing expectAsync1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -36 lines)			Patch
M	pkg/http/test/client_test.dart	View	1 chunk	+11 lines, -9 lines	0 comments	Download
M	pkg/http/test/http_test.dart	View	3 chunks	+10 lines, -8 lines	0 comments	Download
M	pkg/http/test/request_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/oauth2/test/authorization_code_grant_test.dart	View	6 chunks	+16 lines, -11 lines	0 comments	Download
M	pkg/oauth2/test/client_test.dart	View	5 chunks	+14 lines, -4 lines	0 comments	Download
M	pkg/serialization/lib/src/mirrors_helpers.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/integers_patch.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/tests/vm/dart/isolate_unhandled_exception_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/tests/vm/dart/isolate_unhandled_exception_uri_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/standalone/io/https_client_certificate_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/test_extension_fail_test.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

LGTM https://codereview.chromium.org/11801008/diff/1/pkg/http/test/request_test.dart File pkg/http/test/request_test.dart (right): https://codereview.chromium.org/11801008/diff/1/pkg/http/test/request_test.dart#newcode218 pkg/http/test/request_test.dart:218: var future = request.send().catchError((e) { Should there be ...

7 years, 11 months ago (2013-01-07 11:56:44 UTC) #2

Anders Johnsen

7 years, 11 months ago (2013-01-07 11:59:22 UTC) #3

Ty, landing.

https://codereview.chromium.org/11801008/diff/1/pkg/http/test/request_test.dart
File pkg/http/test/request_test.dart (right):

https://codereview.chromium.org/11801008/diff/1/pkg/http/test/request_test.da...
pkg/http/test/request_test.dart:218: var future = request.send().catchError((e)
{
On 2013/01/07 11:56:44, Mads Ager wrote:
> Should there be an expectAsync1 here?

Yes, adding.

Expand Messages | Collapse Messages

Issue 11801008: Fix tests for VM in checked mode. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add missing expectAsync1 #

Messages