Fix tests for VM in checked mode.

pkg/oauth2/test/authorization_code_grant_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library authorization_code_grant_test;
 
+import 'dart:async';
 import 'dart:io';
-import 'dart:json';
+import 'dart:json' as JSON;
 import 'dart:uri';
 
 import '../../unittest/lib/unittest.dart';
 import '../../http/lib/http.dart' as http;
 import '../../http/lib/testing.dart';
 import '../lib/oauth2.dart' as oauth2;
 import 'utils.dart';
 
 final redirectUrl = new Uri.fromString('http://example.com/redirect');
 
@@ skipping 63 matching lines @@
       expect(authorizationUrl.toString(),
           equals('https://example.com/authorization'
               '?query=value'
               '&response_type=code'
               '&client_id=identifier'
               '&redirect_uri=http%3A%2F%2Fexample.com%2Fredirect'));
     });
 
     test("can't be called twice", () {
       grant.getAuthorizationUrl(redirectUrl);
-      expectFutureThrows(grant.getAuthorizationUrl(redirectUrl),
-                        (e) => e is StateError);
+      expect(() => grant.getAuthorizationUrl(redirectUrl), throwsStateError);
     });
   });
 
   group('.handleAuthorizationResponse', () {
     setUp(createGrant);
 
     test("can't be called before .getAuthorizationUrl", () {
       expectFutureThrows(grant.handleAuthorizationResponse({}),
                          (e) => e is StateError);
     });
 
     test("can't be called twice", () {
       grant.getAuthorizationUrl(redirectUrl);
-      grant.handleAuthorizationResponse({'code': 'auth code'});
+      expectFutureThrows(
+          grant.handleAuthorizationResponse({'code': 'auth code'}),
+          (e) => e is FormatException);
       expectFutureThrows(
           grant.handleAuthorizationResponse({'code': 'auth code'}),
           (e) => e is StateError);
     });
 
     test('must have a state parameter if the authorization URL did', () {
       grant.getAuthorizationUrl(redirectUrl, state: 'state');
       expectFutureThrows(
           grant.handleAuthorizationResponse({'code': 'auth code'}),
           (e) => e is FormatException);
@@ skipping 10 matching lines @@
     test('must have a code parameter', () {
       grant.getAuthorizationUrl(redirectUrl);
       expectFutureThrows(grant.handleAuthorizationResponse({}),
                          (e) => e is FormatException);
     });
 
     test('with an error parameter throws an AuthorizationException', () {
       grant.getAuthorizationUrl(redirectUrl);
       expectFutureThrows(
           grant.handleAuthorizationResponse({'error': 'invalid_request'}),
-          (e) => e is AuthorizationException);
+          (e) => e is oauth2.AuthorizationException);
     });
 
     test('sends an authorization code request', () {
       grant.getAuthorizationUrl(redirectUrl);
       client.expectRequest((request) {
         expect(request.method, equals('POST'));
         expect(request.url.toString(), equals(grant.tokenEndpoint.toString()));
         expect(request.bodyFields, equals({
           'grant_type': 'authorization_code',
           'code': 'auth code',
           'redirect_uri': redirectUrl.toString(),
           'client_id': 'identifier',
           'client_secret': 'secret'
         }));
 
         return new Future.immediate(new http.Response(JSON.stringify({
           'access_token': 'access token',
           'token_type': 'bearer',
         }), 200, headers: {'content-type': 'application/json'}));
       });
 
-      expect(grant.handleAuthorizationResponse({'code': 'auth code'}),
-          completion(predicate((client) {
+      grant.handleAuthorizationResponse({'code': 'auth code'})
+          .then(expectAsync1((client) {
             expect(client.credentials.accessToken, equals('access token'));
-            return true;
-          })));
+          }));
     });
   });
 
   group('.handleAuthorizationCode', () {
     setUp(createGrant);
 
     test("can't be called before .getAuthorizationUrl", () {
-      expect(grant.handleAuthorizationCode('auth code'), throwsStateError);
+      expectFutureThrows(
+          grant.handleAuthorizationCode('auth code'),
+          (e) => e is StateError);
     });
 
     test("can't be called twice", () {
       grant.getAuthorizationUrl(redirectUrl);
-      grant.handleAuthorizationCode('auth code');
+      expectFutureThrows(
+          grant.handleAuthorizationCode('auth code'),
+          (e) => e is FormatException);
       expectFutureThrows(grant.handleAuthorizationCode('auth code'),
                          (e) => e is StateError);
     });
 
     test('sends an authorization code request', () {
       grant.getAuthorizationUrl(redirectUrl);
       client.expectRequest((request) {
         expect(request.method, equals('POST'));
         expect(request.url.toString(), equals(grant.tokenEndpoint.toString()));
         expect(request.bodyFields, equals({
@@ skipping 11 matching lines @@
       });
 
       expect(grant.handleAuthorizationCode('auth code'),
           completion(predicate((client) {
             expect(client.credentials.accessToken, equals('access token'));
             return true;
           })));
     });
   });
 }