Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1160)

Issue 11800002: "Reverting 16675-16676, 71-73" (Closed)

Created:
7 years, 11 months ago by Emily Fortuna
Modified:
7 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reverting everything because package root + dartium is causing serious problems. DART_PACKAGE_ROOT environment variable is set for drt, but not dartium, and is location is problematic with respect to serving the files in the dartium checkout. Committed: https://code.google.com/p/dart/source/detail?r=16678

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -270 lines) Patch
M pkg/intl/test/bidi_format_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/intl/test/bidi_utils_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/intl/test/date_time_format_file_test_stub.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/intl/test/date_time_format_http_request_test.dart View 2 chunks +11 lines, -8 lines 0 comments Download
M pkg/intl/test/date_time_format_local_test_stub.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/intl/test/date_time_format_test_core.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/intl/test/date_time_format_uninitialized_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/intl/test/find_default_locale_browser_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/intl/test/find_default_locale_standalone_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/intl/test/intl_message_basic_example_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/intl/test/intl_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/intl/test/number_format_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M samples/tests/samples/samples.status View 1 1 chunk +0 lines, -3 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +5 lines, -12 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +5 lines, -12 lines 0 comments Download
M tests/co19/test_config.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/exceptions_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/form_data_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/html.status View 4 chunks +4 lines, -0 lines 0 comments Download
M tests/html/xhr_cross_origin_test.dart View 3 chunks +2 lines, -30 lines 0 comments Download
M tests/html/xhr_test.dart View 1 chunk +4 lines, -48 lines 0 comments Download
M tools/dom/src/_HttpRequestUtils.dart View 1 chunk +5 lines, -12 lines 0 comments Download
M tools/test.dart View 3 chunks +14 lines, -19 lines 0 comments Download
M tools/testing/dart/browser_test.dart View 1 chunk +10 lines, -12 lines 0 comments Download
M tools/testing/dart/http_server.dart View 3 chunks +12 lines, -26 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 10 chunks +18 lines, -34 lines 0 comments Download
M tools/testing/run_selenium.py View 1 chunk +18 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Emily Fortuna
7 years, 11 months ago (2013-01-05 05:19:42 UTC) #1
Bob Nystrom
7 years, 11 months ago (2013-01-07 18:30:03 UTC) #2
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698