"Reverting 16675-16676, 71-73"

tools/dom/src/_HttpRequestUtils.dart

Index: tools/dom/src/_HttpRequestUtils.dart
diff --git a/tools/dom/src/_HttpRequestUtils.dart b/tools/dom/src/_HttpRequestUtils.dart
index 11c12833ed99a8fa3aba2a8a04cc21d61eac7966..36a46ec94ea7424a7bff24dcacf0285a22daa328 100644
--- a/tools/dom/src/_HttpRequestUtils.dart
+++ b/tools/dom/src/_HttpRequestUtils.dart
@@ -8,25 +8,18 @@ class _HttpRequestUtils {
 
   // Helper for factory HttpRequest.get
   static HttpRequest get(String url,
-                            onComplete(HttpRequest request),
+                            onSuccess(HttpRequest request),
                             bool withCredentials) {
     final request = new HttpRequest();
     request.open('GET', url, true);
 
     request.withCredentials = withCredentials;
 
+    // Status 0 is for local XHR request.
     request.on.readyStateChange.add((e) {
-      if (request.readyState == HttpRequest.DONE) {
-        // TODO(efortuna): Previously HttpRequest.get only invoked the callback
-        // when request.status was 0 or 200. This
-        // causes two problems 1) request.status = 0 for ANY local XHR request
-        // (file found or not found) 2) the user facing function claims that the
-        // callback is called on completion of the request, regardless of
-        // status. Because the new event model is coming in soon, rather than
-        // fixing the callbacks version, we just need to revisit the desired
-        // behavior when we're using streams/futures.
-        // Status 0 is for local XHR request.
-        onComplete(request);
+      if (request.readyState == HttpRequest.DONE &&
+          (request.status == 200 || request.status == 0)) {
+        onSuccess(request);
       }
     });