Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1179503002: dart2js cps: Handle type variables in factory constructors. (Closed)

Created:
5 years, 6 months ago by asgerf
Modified:
5 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Handle type variables in factory constructors. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/ff104736f2c69a9b27ffb567306754092cde78ab

Patch Set 1 #

Patch Set 2 : Status files #

Patch Set 3 : Fix status #

Total comments: 4

Patch Set 4 : Type argument #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 2 3 1 chunk +9 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 chunks +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 2 chunks +0 lines, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 5 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
asgerf
5 years, 6 months ago (2015-06-10 12:43:10 UTC) #2
karlklose
LGTM! https://codereview.chromium.org/1179503002/diff/40001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right): https://codereview.chromium.org/1179503002/diff/40001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart#newcode195 pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:195: List<Local> parameters = []; Add type argument. https://codereview.chromium.org/1179503002/diff/40001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart#newcode196 ...
5 years, 6 months ago (2015-06-10 12:55:22 UTC) #3
asgerf
https://codereview.chromium.org/1179503002/diff/40001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right): https://codereview.chromium.org/1179503002/diff/40001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart#newcode195 pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:195: List<Local> parameters = []; On 2015/06/10 12:55:22, karlklose wrote: ...
5 years, 6 months ago (2015-06-10 13:01:17 UTC) #4
asgerf
5 years, 6 months ago (2015-06-10 13:04:48 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
ff104736f2c69a9b27ffb567306754092cde78ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698