dart2js cps: Handle type variables in factory constructors.

pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.ir_builder_task;
 
 import '../closure.dart' as closurelib;
 import '../closure.dart' hide ClosureScope;
 import '../constants/expressions.dart';
 import '../dart_types.dart';
@@ skipping 174 matching lines @@
 
   /// Like [useSelectorType], except the original typed selector is obtained
   /// from the [node].
   Selector useSelectorTypeOfNode(Selector newSelector, ast.Send node) {
     return useSelectorType(newSelector, elements.getSelector(node));
   }
 
   ir.FunctionDefinition _makeFunctionBody(FunctionElement element,
                                           ast.FunctionExpression node) {
     FunctionSignature signature = element.functionSignature;
-    List<ParameterElement> parameters = [];
-    signature.orderedForEachParameter(parameters.add);
+    List<Local> parameters = [];

[karlklose, 2015/06/10 12:55:22]

Add type argument.

[asgerf, 2015/06/10 13:01:17]

Done.

+    signature.orderedForEachParameter((e) => parameters.add(e));

[karlklose, 2015/06/10 12:55:22]

Is this because of type warnings?

[asgerf, 2015/06/10 13:01:17]

Yup. :(

+
+    if (element.isFactoryConstructor) {
+      // Type arguments are passed in as extra parameters.
+      for (DartType typeVariable in element.enclosingClass.typeVariables) {
+        parameters.add(new TypeVariableLocal(typeVariable, element));
+      }
+    }
 
     irBuilder.buildFunctionHeader(parameters,
                                   closureScope: getClosureScopeForNode(node),
                                   env: getClosureEnvironment());
 
     visit(node.body);
     return irBuilder.makeFunctionDefinition();
   }
 
   ir.Primitive visit(ast.Node node) => node.accept(this);
@@ skipping 2643 matching lines @@
   }
 
   processSetStatic(ir.SetStatic node) {
     node.body = replacementFor(node.body);
   }
 
   processContinuation(ir.Continuation node) {
     node.body = replacementFor(node.body);
   }
 }