Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 11794043: Remove Signal class and use Future/.whenComplete instead. (Closed)

Created:
7 years, 11 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 11 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove Signal class and use Future/.whenComplete instead. Committed: https://code.google.com/p/dart/source/detail?r=16792

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comment updated. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -142 lines) Patch
M sdk/lib/async/async.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/async/async_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/async/future.dart View 1 1 chunk +14 lines, -6 lines 0 comments Download
M sdk/lib/async/future_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
D sdk/lib/async/signal.dart View 1 chunk +0 lines, -98 lines 0 comments Download
M sdk/lib/async/stream.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/async/stream_controller.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/stream_impl.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/lib/async/event_helper.dart View 4 chunks +7 lines, -7 lines 0 comments Download
M tests/lib/async/stream_controller_async_test.dart View 8 chunks +18 lines, -16 lines 0 comments Download
M tests/lib/async/stream_controller_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein Nielsen
I recognized the same problem as dartbug.com/7762 though. Signal didn't need error handling. We can ...
7 years, 11 months ago (2013-01-08 08:38:27 UTC) #1
floitsch
7 years, 11 months ago (2013-01-08 12:24:40 UTC) #2
LGTM.

https://codereview.chromium.org/11794043/diff/1/sdk/lib/async/future.dart
File sdk/lib/async/future.dart (right):

https://codereview.chromium.org/11794043/diff/1/sdk/lib/async/future.dart#new...
sdk/lib/async/future.dart:147: /** Supply a value for [future], or supply
[:null:] if a value is omitted. */
dartdoc comments should be third person:

/// Completes the [future] with the [value].
///
/// All subscriber of the [future] will be immediately informed of the
completion.

(or something similar).

I'm not sure we need to specify that the default value is `null`.

Powered by Google App Engine
This is Rietveld 408576698