Remove Signal class and use Future/.whenComplete instead.

tests/lib/async/stream_controller_async_test.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Test the basic StreamController and StreamController.singleSubscription.
 library stream_controller_async_test;
 
 import 'dart:async';
 import 'dart:isolate';
 import '../../../pkg/unittest/lib/unittest.dart';
 import 'event_helper.dart';
 
 testController() {
   // Test reduce
   test("StreamController.reduce", () {
     StreamController c = new StreamController();
     c.reduce(0, (a,b) => a + b)
-    .then(expectAsync1((int v) {
+     .then(expectAsync1((int v) {
         Expect.equals(42, v);
     }));
     c.add(10);
     c.add(32);
     c.close();
   });
 
   test("StreamController.reduce throws", () {
     StreamController c = new StreamController();
     c.reduce(0, (a,b) { throw "Fnyf!"; })
-            .catchError(expectAsync1((e) {
-              Expect.equals("Fnyf!", e.error);
-            }));
+     .catchError(expectAsync1((e) { Expect.equals("Fnyf!", e.error); }));
     c.add(42);
   });
 
   test("StreamController.pipeInto", () {
     StreamController c = new StreamController();
     var list = <int>[];
     c.pipeInto(new CollectionSink<int>(list))
-     .then(expectAsync0(() { Expect.listEquals(<int>[1,2,9,3,9], list); }));
+     .whenComplete(expectAsync0(() {
+        Expect.listEquals(<int>[1,2,9,3,9], list);
+      }));
     c.add(1);
     c.add(2);
     c.add(9);
     c.add(3);
     c.add(9);
     c.close();
   });
 }
 
 testSingleController() {
@@ skipping 10 matching lines @@
     StreamController c = new StreamController.singleSubscription();
     c.reduce(0, (a,b) { throw "Fnyf!"; })
             .catchError(expectAsync1((e) { Expect.equals("Fnyf!", e.error); }));
     c.add(42);
   });
 
   test("Single-subscription StreamController.pipeInto", () {
     StreamController c = new StreamController.singleSubscription();
     var list = <int>[];
     c.pipeInto(new CollectionSink<int>(list))
-     .then(expectAsync0(() { Expect.listEquals(<int>[1,2,9,3,9], list); }));
+     .whenComplete(expectAsync0(() {
+        Expect.listEquals(<int>[1,2,9,3,9], list);
+      }));
     c.add(1);
     c.add(2);
     c.add(9);
     c.add(3);
     c.add(9);
     c.close();
   });
 
   test("Single-subscription StreamController subscription changes", () {
     StreamController c = new StreamController.singleSubscription();
@@ skipping 202 matching lines @@
 }
 
 testPause() {
   test("pause event-unpause", () {
     StreamController c = new StreamController();
     Events actualEvents = new Events.capture(c);
     Events expectedEvents = new Events();
     expectedEvents.add(42);
     c.add(42);
     Expect.listEquals(expectedEvents.events, actualEvents.events);
-    SignalCompleter completer = new SignalCompleter();
-    actualEvents.pause(completer.signal);
+    Completer completer = new Completer();
+    actualEvents.pause(completer.future);
     c..add(43)..add(44)..close();
     Expect.listEquals(expectedEvents.events, actualEvents.events);
     completer.complete();
     expectedEvents..add(43)..add(44)..close();
     actualEvents.onDone(expectAsync0(() {
       Expect.listEquals(expectedEvents.events, actualEvents.events);
     }));
   });
 
   test("pause twice event-unpause", () {
     StreamController c = new StreamController();
     Events actualEvents = new Events.capture(c);
     Events expectedEvents = new Events();
     expectedEvents.add(42);
     c.add(42);
     Expect.listEquals(expectedEvents.events, actualEvents.events);
-    SignalCompleter completer = new SignalCompleter();
-    SignalCompleter completer2 = new SignalCompleter();
-    actualEvents.pause(completer.signal);
-    actualEvents.pause(completer2.signal);
+    Completer completer = new Completer();
+    Completer completer2 = new Completer();
+    actualEvents.pause(completer.future);
+    actualEvents.pause(completer2.future);
     c..add(43)..add(44)..close();
     Expect.listEquals(expectedEvents.events, actualEvents.events);
     completer.complete();
     Expect.listEquals(expectedEvents.events, actualEvents.events);
     completer2.complete();
     expectedEvents..add(43)..add(44)..close();
     actualEvents.onDone(expectAsync0((){
       Expect.listEquals(expectedEvents.events, actualEvents.events);
     }));
   });
@@ skipping 20 matching lines @@
     actualEvents.resume();
   });
 
   test("pause twice direct-event-unpause", () {
     StreamController c = new StreamController();
     Events actualEvents = new Events.capture(c);
     Events expectedEvents = new Events();
     expectedEvents.add(42);
     c.add(42);
     Expect.listEquals(expectedEvents.events, actualEvents.events);
-    SignalCompleter completer = new SignalCompleter();
-    actualEvents.pause(completer.signal);
+    Completer completer = new Completer();
+    actualEvents.pause(completer.future);
     actualEvents.pause();
     c.add(43);
     c.add(44);
     c.close();
     Expect.listEquals(expectedEvents.events, actualEvents.events);
     actualEvents.resume();
     Expect.listEquals(expectedEvents.events, actualEvents.events);
     expectedEvents..add(43)..add(44)..close();
     actualEvents.onDone(expectAsync0(() {
       Expect.listEquals(expectedEvents.events, actualEvents.events);
     }));
     completer.complete();
   });
 
   test("pause twice direct-unpause", () {
     StreamController c = new StreamController();
     Events actualEvents = new Events.capture(c);
     Events expectedEvents = new Events();
     expectedEvents.add(42);
     c.add(42);
     Expect.listEquals(expectedEvents.events, actualEvents.events);
-    SignalCompleter completer = new SignalCompleter();
-    actualEvents.pause(completer.signal);
+    Completer completer = new Completer();
+    actualEvents.pause(completer.future);
     actualEvents.pause();
     c.add(43);
     c.add(44);
     c.close();
     Expect.listEquals(expectedEvents.events, actualEvents.events);
     completer.complete();
     Expect.listEquals(expectedEvents.events, actualEvents.events);
     expectedEvents..add(43)..add(44)..close();
     actualEvents.onDone(expectAsync0(() {
       Expect.listEquals(expectedEvents.events, actualEvents.events);
     }));
     actualEvents.resume();
   });
 }
 
 main() {
   testController();
   testSingleController();
   testExtraMethods();
   testPause();
 }