Issue 11785006: Support Null type in Class::TypeTest and simplify Instance::IsInstanceOf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11785006: Support Null type in Class::TypeTest and simplify Instance::IsInstanceOf. (Closed)

Created:
7 years, 11 months ago by regis

Modified:
7 years, 11 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Support Null type in Class::TypeTest and simplify Instance::IsInstanceOf. Committed: https://code.google.com/p/dart/source/detail?r=16664

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -51 lines)			Patch
M	runtime/lib/object.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	1 chunk	+4 lines, -9 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	2 chunks	+6 lines, -41 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://codereview.chromium.org/11785006/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/11785006/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode1267 runtime/vm/flow_graph_optimizer.cc:1267: bool is_subtype = cls.IsSubtypeOf(TypeArguments::Handle(), const bool is_subtype https://codereview.chromium.org/11785006/diff/1/runtime/vm/object.cc ...

7 years, 11 months ago (2013-01-05 00:38:58 UTC) #2

regis

7 years, 11 months ago (2013-01-05 00:45:38 UTC) #3

Thanks!

https://codereview.chromium.org/11785006/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/11785006/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:1267: bool is_subtype =
cls.IsSubtypeOf(TypeArguments::Handle(),
On 2013/01/05 00:38:58, srdjan wrote:
> const bool is_subtype

Done.

https://codereview.chromium.org/11785006/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/11785006/diff/1/runtime/vm/object.cc#newcode2034
runtime/vm/object.cc:2034: other.IsObjectClass() || other.IsNullClass();
On 2013/01/05 00:38:58, srdjan wrote:
> || other.IsDynamicClass()

See comment on line 2032.

Expand Messages | Collapse Messages

Issue 11785006: Support Null type in Class::TypeTest and simplify Instance::IsInstanceOf. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages