runtime/vm/flow_graph_optimizer.cc - Issue 11785006: Support Null type in Class::TypeTest and simplify Instance::IsInstanceOf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 11785006: Support Null type in Class::TypeTest and simplify Instance::IsInstanceOf. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_optimizer.cc

===================================================================

--- runtime/vm/flow_graph_optimizer.cc (revision 16663)

+++ runtime/vm/flow_graph_optimizer.cc (working copy)

@@ -1264,15 +1264,10 @@

for (int i = 0; i < ic_data.NumberOfChecks(); i++) {

cls = class_table.At(ic_data.GetReceiverClassIdAt(i));

if (cls.HasTypeArguments()) return Bool::null();

- bool is_subtype = false;

- if (cls.IsNullClass()) {

- is_subtype = type_class.IsDynamicClass() || type_class.IsObjectClass();

- } else {

- is_subtype = cls.IsSubtypeOf(TypeArguments::Handle(),

- type_class,

- TypeArguments::Handle(),

- NULL);

- }

+ const bool is_subtype = cls.IsSubtypeOf(TypeArguments::Handle(),

+ type_class,

+ TypeArguments::Handle(),

+ NULL);

if (prev.IsNull()) {

prev = is_subtype ? Bool::True().raw() : Bool::False().raw();

} else {

« no previous file with comments | « runtime/lib/object.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »