Issue 1177963002: Build LIBRARY_ELEMENT after RESOLVED_UNIT6 for all units in the closure of a library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1177963002: Build LIBRARY_ELEMENT after RESOLVED_UNIT6 for all units in the closure of a library. (Closed)

Created:
5 years, 6 months ago by scheglov

Modified:
5 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Build LIBRARY_ELEMENT after RESOLVED_UNIT6 for all units in the closure of a library. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f584413999c63cb571df9db89273168085518b60

Patch Set 1 #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+96 lines, -26 lines)			Patch
M	pkg/analyzer/lib/src/context/context.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/plugin/engine_plugin.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/task/dart.dart	View	14 chunks	+88 lines, -16 lines	1 comment	Download
M	pkg/analyzer/test/src/task/dart_test.dart	View	5 chunks	+5 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1177963002/diff/1/pkg/analyzer/lib/src/task/dart.dart File pkg/analyzer/lib/src/task/dart.dart (right): https://codereview.chromium.org/1177963002/diff/1/pkg/analyzer/lib/src/task/dart.dart#newcode2128 pkg/analyzer/lib/src/task/dart.dart:2128: 'libraryElement': LIBRARY_ELEMENT.of(target.library), In a future CL, we should ...

5 years, 6 months ago (2015-06-11 13:52:54 UTC) #2

scheglov

5 years, 6 months ago (2015-06-11 15:06:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f584413999c63cb571df9db89273168085518b60 (presubmit successful).

Expand Messages | Collapse Messages