Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: pkg/analyzer/lib/src/plugin/engine_plugin.dart

Issue 1177963002: Build LIBRARY_ELEMENT after RESOLVED_UNIT6 for all units in the closure of a library. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyzer.src.plugin.engine_plugin; 5 library analyzer.src.plugin.engine_plugin;
6 6
7 import 'package:analyzer/plugin/task.dart'; 7 import 'package:analyzer/plugin/task.dart';
8 import 'package:analyzer/src/task/dart.dart'; 8 import 'package:analyzer/src/task/dart.dart';
9 import 'package:analyzer/src/task/general.dart'; 9 import 'package:analyzer/src/task/general.dart';
10 import 'package:analyzer/task/model.dart'; 10 import 'package:analyzer/task/model.dart';
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 registerExtension(taskId, ComputeConstantValueTask.DESCRIPTOR); 76 registerExtension(taskId, ComputeConstantValueTask.DESCRIPTOR);
77 registerExtension(taskId, ContainingLibrariesTask.DESCRIPTOR); 77 registerExtension(taskId, ContainingLibrariesTask.DESCRIPTOR);
78 registerExtension(taskId, DartErrorsTask.DESCRIPTOR); 78 registerExtension(taskId, DartErrorsTask.DESCRIPTOR);
79 registerExtension(taskId, EvaluateUnitConstantsTask.DESCRIPTOR); 79 registerExtension(taskId, EvaluateUnitConstantsTask.DESCRIPTOR);
80 registerExtension(taskId, GatherUsedImportedElementsTask.DESCRIPTOR); 80 registerExtension(taskId, GatherUsedImportedElementsTask.DESCRIPTOR);
81 registerExtension(taskId, GatherUsedLocalElementsTask.DESCRIPTOR); 81 registerExtension(taskId, GatherUsedLocalElementsTask.DESCRIPTOR);
82 registerExtension(taskId, GenerateHintsTask.DESCRIPTOR); 82 registerExtension(taskId, GenerateHintsTask.DESCRIPTOR);
83 registerExtension(taskId, LibraryErrorsReadyTask.DESCRIPTOR); 83 registerExtension(taskId, LibraryErrorsReadyTask.DESCRIPTOR);
84 registerExtension(taskId, LibraryUnitErrorsTask.DESCRIPTOR); 84 registerExtension(taskId, LibraryUnitErrorsTask.DESCRIPTOR);
85 registerExtension(taskId, ParseDartTask.DESCRIPTOR); 85 registerExtension(taskId, ParseDartTask.DESCRIPTOR);
86 registerExtension(taskId, ResolveLibraryReferencesTask.DESCRIPTOR);
86 registerExtension(taskId, ResolveLibraryTypeNamesTask.DESCRIPTOR); 87 registerExtension(taskId, ResolveLibraryTypeNamesTask.DESCRIPTOR);
87 registerExtension(taskId, ResolveReferencesTask.DESCRIPTOR); 88 registerExtension(taskId, ResolveUnitReferencesTask.DESCRIPTOR);
88 registerExtension(taskId, ResolveUnitTypeNamesTask.DESCRIPTOR); 89 registerExtension(taskId, ResolveUnitTypeNamesTask.DESCRIPTOR);
89 registerExtension(taskId, ResolveVariableReferencesTask.DESCRIPTOR); 90 registerExtension(taskId, ResolveVariableReferencesTask.DESCRIPTOR);
90 registerExtension(taskId, ScanDartTask.DESCRIPTOR); 91 registerExtension(taskId, ScanDartTask.DESCRIPTOR);
91 registerExtension(taskId, VerifyUnitTask.DESCRIPTOR); 92 registerExtension(taskId, VerifyUnitTask.DESCRIPTOR);
92 // 93 //
93 // Register HTML tasks. 94 // Register HTML tasks.
94 // 95 //
95 } 96 }
96 97
97 /** 98 /**
98 * Validate the given extension by throwing an [ExtensionError] if it is not a 99 * Validate the given extension by throwing an [ExtensionError] if it is not a
99 * valid domain. 100 * valid domain.
100 */ 101 */
101 void _validateTaskExtension(Object extension) { 102 void _validateTaskExtension(Object extension) {
102 if (extension is! TaskDescriptor) { 103 if (extension is! TaskDescriptor) {
103 String id = taskExtensionPoint.uniqueIdentifier; 104 String id = taskExtensionPoint.uniqueIdentifier;
104 throw new ExtensionError('Extensions to $id must be a TaskDescriptor'); 105 throw new ExtensionError('Extensions to $id must be a TaskDescriptor');
105 } 106 }
106 } 107 }
107 } 108 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698