Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Issue 11773045: Factor out length check in list factories: reduce bloat, factorize code, improve performance. (Closed)

Created:
7 years, 11 months ago by srdjan
Modified:
7 years, 11 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, Vyacheslav Egorov (Google)
Visibility:
Public.

Description

Factor out length check in list factories: reduce bloat, factorize code, improve performance. Committed: https://code.google.com/p/dart/source/detail?r=16810

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M runtime/lib/array_patch.dart View 1 2 3 chunks +8 lines, -5 lines 0 comments Download
M runtime/lib/growable_array.dart View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
srdjan
7 years, 11 months ago (2013-01-08 17:06:02 UTC) #1
srdjan
7 years, 11 months ago (2013-01-08 17:06:17 UTC) #2
srdjan
Added Ivan's suggestions.
7 years, 11 months ago (2013-01-08 17:37:33 UTC) #3
Ivan Posva
7 years, 11 months ago (2013-01-08 17:46:45 UTC) #4
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698