Factor out length check in list factories: reduce bloat, factorize code, improve performance.

runtime/lib/growable_array.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class _GrowableObjectArray<T> implements List<T> {
   factory _GrowableObjectArray._uninstantiable() {
     throw new UnsupportedError(
         "GrowableObjectArray can only be allocated by the VM");
   }
 
@@ skipping 54 matching lines @@
 
   List<T> getRange(int start, int length) {
     if (length == 0) return [];
     Arrays.rangeCheck(this, start, length);
     List list = new _GrowableObjectArray<T>.withCapacity(length);
     list.length = length;
     Arrays.copy(this, start, list, 0, length);
     return list;
   }
 
-  factory _GrowableObjectArray() {
-    var data = new _ObjectArray<T>(4);
-    return new _GrowableObjectArray<T>.fromObjectArray(data);
+  factory _GrowableObjectArray(int length) {
+    var data = new _ObjectArray<T>((length == 0) ? 4 : length);
+    var result = new _GrowableObjectArray<T>.fromObjectArray(data);
+    result._setLength(length);
+    return result;
   }
 
   factory _GrowableObjectArray.withCapacity(int capacity) {
     var data = new _ObjectArray<T>((capacity == 0)? 4 : capacity);
     return new _GrowableObjectArray<T>.fromObjectArray(data);
   }
 
   factory _GrowableObjectArray.from(Collection<T> other) {
     List<T> result = new _GrowableObjectArray<T>();
     result.addAll(other);
@@ skipping 200 matching lines @@
   }
 
   List<T> toList() {
     return new List<T>.from(this);
   }
 
   Set<T> toSet() {
     return new Set<T>.from(this);
   }
 }