Issue 1177063002: Detect zero receiver of modInverse (may not converge and time out

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1177063002: Detect zero receiver of modInverse (may not converge and time out (Closed)

Created:
5 years, 6 months ago by regis

Modified:
5 years, 6 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Detect zero receiver of modInverse (may not converge and time out in that case). See #23502 Committed: https://github.com/dart-lang/sdk/commit/9edc6e5a6d31ec926be7743c06f500f125a04b54

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -0 lines)			Patch
M	runtime/lib/bigint.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/lib/integers.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/js_number.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/core/int.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/corelib/big_integer_arith_vm_test.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

regis

TBR Let's discuss later if it is better to throw (what error?) in case the ...

5 years, 6 months ago (2015-06-10 23:39:16 UTC) #1

regis

Committed patchset #1 (id:1) manually as 9edc6e5a6d31ec926be7743c06f500f125a04b54 (presubmit successful).

5 years, 6 months ago (2015-06-10 23:40:28 UTC) #2

Message was sent while issue was closed.

lgtm