runtime/lib/integers.dart - Issue 1177063002: Detect zero receiver of modInverse (may not converge and time out

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/integers.dart

Issue 1177063002: Detect zero receiver of modInverse (may not converge and time out (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/lib/integers.dart

diff --git a/runtime/lib/integers.dart b/runtime/lib/integers.dart

index 5bee4047dbd11db280680ebdff7e562ee85e1368..7302e19fc0c78e41f479501922d84d25713a0fd9 100644

--- a/runtime/lib/integers.dart

+++ b/runtime/lib/integers.dart

@@ -297,6 +297,7 @@ class _IntegerImplementation extends _Num {

if (m is _Bigint) {

return _toBigint().modInverse(m);

}

+ if (this == 0) return 0;

bool ac = m.isEven;

int u = m;

int v = this;

« no previous file with comments | « runtime/lib/bigint.dart ('k') | sdk/lib/_internal/compiler/js_lib/js_number.dart » ('j') | no next file with comments »