Issue 1175753002: Move some state-tracking to Engine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1175753002: Move some state-tracking to Engine. (Closed)

Created:
5 years, 6 months ago by nweiz

Modified:
5 years, 6 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

Move some state-tracking to Engine. This reduces a bit of the duplication between the compact and expanded reporters, and sets the stage for better loading in the future. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/2d5e3a09b451665b1963e7eb92036590c93d3041

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -85 lines)			Patch
M	lib/src/runner/engine.dart	View		3 chunks	+34 lines, -0 lines	0 comments	Download
M	lib/src/runner/reporter/compact.dart	View		7 chunks	+23 lines, -42 lines	0 comments	Download
M	lib/src/runner/reporter/expanded.dart	View		6 chunks	+24 lines, -42 lines	0 comments	Download
M	pubspec.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

nweiz

5 years, 6 months ago (2015-06-09 22:22:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
2d5e3a09b451665b1963e7eb92036590c93d3041 (presubmit successful).