Move some state-tracking to Engine.

lib/src/runner/reporter/expanded.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.runner.reporter.no_io_compact;
 
 import 'dart:async';
 
 import '../../backend/live_test.dart';
 import '../../backend/state.dart';
@@ skipping 37 matching lines @@
 
   /// Whether multiple test files are being run.
   final bool _multiplePaths;
 
   /// Whether tests are being run on multiple platforms.
   final bool _multiplePlatforms;
 
   /// A stopwatch that tracks the duration of the full run.
   final _stopwatch = new Stopwatch();
 
-  /// The set of tests that have completed and been marked as passing.
-  final _passed = new Set<LiveTest>();
-
-  /// The set of tests that have completed and been marked as skipped.
-  final _skipped = new Set<LiveTest>();
-
-  /// The set of tests that have completed and been marked as failing or error.
-  final _failed = new Set<LiveTest>();
-
-  /// The set of tests that are still running.
-  final _active = new List<LiveTest>();
-
   /// Whether [close] has been called.
   bool _closed = false;
 
-  /// The size of [_passed] last time a progress notification was printed.
+  /// The size of `_engine.passed` last time a progress notification was
+  /// printed.
   int _lastProgressPassed;
 
-  /// The size of [_skipped] last time a progress notification was printed.
+  /// The size of `_engine.skipped` last time a progress notification was
+  /// printed.
   int _lastProgressSkipped;
 
-  /// The size of [_failed] last time a progress notification was printed.
+  /// The size of `_engine.failed` last time a progress notification was
+  /// printed.
   int _lastProgressFailed;
 
   /// The message printed for the last progress notification.
   String _lastProgressMessage;
 
   /// Creates a [NoIoCompactReporter] that will run all tests in [suites].
   ///
   /// [concurrency] controls how many suites are run at once. If [color] is
   /// `true`, this will use terminal colors; if it's `false`, it won't. If
   /// [verboseTrace] is `true`, this will print core library frames.
   ExpandedReporter(Iterable<Suite> suites, {int concurrency, bool color: true,
           bool verboseTrace: false})
       : _multiplePaths = suites.map((suite) => suite.path).toSet().length > 1,
         _multiplePlatforms =
             suites.map((suite) => suite.platform).toSet().length > 1,
         _engine = new Engine(suites, concurrency: concurrency),
         _verboseTrace = verboseTrace,
         _green = color ? '\u001b[32m' : '',
         _red = color ? '\u001b[31m' : '',
         _yellow = color ? '\u001b[33m' : '',
         _noColor = color ? '\u001b[0m' : '' {
     _engine.onTestStarted.listen((liveTest) {
-      if (_active.isEmpty) _progressLine(_description(liveTest));
-      _active.add(liveTest);
+      // If this is the first test to start, print a progress line so the user
+      // knows what's running.
+      if (_engine.active.length == 1) _progressLine(_description(liveTest));
 
       liveTest.onStateChange.listen((state) {
         if (state.status != Status.complete) return;
-        _active.remove(liveTest);
-
-        if (state.result != Result.success) {
-          _passed.remove(liveTest);
-          _failed.add(liveTest);
-        } else if (liveTest.test.metadata.skip) {
-          _skipped.add(liveTest);
-        } else {
-          _passed.add(liveTest);
-        }
 
         if (liveTest.test.metadata.skip &&
             liveTest.test.metadata.skipReason != null) {
           _progressLine(_description(liveTest));
           print(indent('${_yellow}Skip: ${liveTest.test.metadata.skipReason}'
               '$_noColor'));
-        } else if (_active.isNotEmpty) {
+        } else if (_engine.active.isNotEmpty) {
           // If any tests are running, display the name of the oldest active
           // test.
-          _progressLine(_description(_active.first));
+          _progressLine(_description(_engine.active.first));
         }
       });
 
       liveTest.onError.listen((error) {
         if (liveTest.state.status != Status.complete) return;
 
         _progressLine(_description(liveTest));
         print(indent(error.error.toString()));
         var chain = terseChain(error.stackTrace, verbose: _verboseTrace);
         print(indent(chain.toString()));
@@ skipping 20 matching lines @@
       print("No tests ran.");
       return true;
     }
 
     _stopwatch.start();
     var success = await _engine.run();
     if (_closed) return false;
 
     if (!success) {
       _progressLine('Some tests failed.', color: _red);
-    } else if (_passed.isEmpty) {
+    } else if (_engine.passed.isEmpty) {
       _progressLine("All tests skipped.");
     } else {
       _progressLine("All tests passed!");
     }
 
     return success;
   }
 
   /// Signals that the caller is done with any test output and the reporter
   /// should release any resources it has allocated.
   Future close() => _engine.close();
 
   /// Prints a line representing the current state of the tests.
   ///
   /// [message] goes after the progress report, and may be truncated to fit the
   /// entire line within [_lineLength]. If [color] is passed, it's used as the
   /// color for [message].
   void _progressLine(String message, {String color}) {
     // Print nothing if nothing has changed since the last progress line.
-    if (_passed.length == _lastProgressPassed &&
-        _skipped.length == _lastProgressSkipped &&
-        _failed.length == _lastProgressFailed &&
+    if (_engine.passed.length == _lastProgressPassed &&
+        _engine.skipped.length == _lastProgressSkipped &&
+        _engine.failed.length == _lastProgressFailed &&
         message == _lastProgressMessage) {
       return;
     }
 
-    _lastProgressPassed = _passed.length;
-    _lastProgressSkipped = _skipped.length;
-    _lastProgressFailed = _failed.length;
+    _lastProgressPassed = _engine.passed.length;
+    _lastProgressSkipped = _engine.skipped.length;
+    _lastProgressFailed = _engine.failed.length;
     _lastProgressMessage = message;
 
     if (color == null) color = '';
     var duration = _stopwatch.elapsed;
     var buffer = new StringBuffer();
 
     // \r moves back to the beginning of the current line.
     buffer.write('${_timeString(duration)} ');
     buffer.write(_green);
     buffer.write('+');
-    buffer.write(_passed.length);
+    buffer.write(_engine.passed.length);
     buffer.write(_noColor);
 
-    if (_skipped.isNotEmpty) {
+    if (_engine.skipped.isNotEmpty) {
       buffer.write(_yellow);
       buffer.write(' ~');
-      buffer.write(_skipped.length);
+      buffer.write(_engine.skipped.length);
       buffer.write(_noColor);
     }
 
-    if (_failed.isNotEmpty) {
+    if (_engine.failed.isNotEmpty) {
       buffer.write(_red);
       buffer.write(' -');
-      buffer.write(_failed.length);
+      buffer.write(_engine.failed.length);
       buffer.write(_noColor);
     }
 
     buffer.write(': ');
     buffer.write(color);
 
     // Ensure the line fits within [_lineLength]. [buffer] includes the color
     // escape sequences too. Because these sequences are not visible characters,
     // we make sure they are not counted towards the limit.
     var nonVisible = 1 + _green.length + _noColor.length + color.length +
-        (_failed.isEmpty ? 0 : _red.length + _noColor.length);
+        (_engine.failed.isEmpty ? 0 : _red.length + _noColor.length);
     var length = buffer.length - nonVisible;
     buffer.write(truncate(message, _lineLength - length));
     buffer.write(_noColor);
 
     print(buffer.toString());
   }
 
   /// Returns a representation of [duration] as `MM:SS`.
   String _timeString(Duration duration) {
     return "${duration.inMinutes.toString().padLeft(2, '0')}:"
@@ skipping 11 matching lines @@
       name = "${liveTest.suite.path}: $name";
     }
 
     if (_multiplePlatforms && liveTest.suite.platform != null) {
       name = "[${liveTest.suite.platform}] $name";
     }
 
     return name;
   }
 }