Issue 11741026: Add a validator for top-level directory names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11741026: Add a validator for top-level directory names. (Closed)

Created:
7 years, 11 months ago by nweiz

Modified:
7 years, 11 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a validator for top-level directory names. BUG=7045 Committed: https://code.google.com/p/dart/source/detail?r=16621

Patch Set 1 #

Total comments: 2

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -1 line)			Patch
M	utils/pub/validator.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download
A	utils/pub/validator/directory.dart	View	1 chunk	+45 lines, -0 lines	2 comments	Download
M	utils/tests/pub/validator_test.dart	View	4 chunks	+25 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One suggestion. Otherwise LGTM. https://codereview.chromium.org/11741026/diff/1/utils/pub/validator/directory.dart File utils/pub/validator/directory.dart (right): https://codereview.chromium.org/11741026/diff/1/utils/pub/validator/directory.dart#newcode33 utils/pub/validator/directory.dart:33: 'tools.'); How about: ''Rename the ...

7 years, 11 months ago (2013-01-03 23:18:54 UTC) #2

nweiz

7 years, 11 months ago (2013-01-04 00:25:15 UTC) #3

https://codereview.chromium.org/11741026/diff/1/utils/pub/validator/directory...
File utils/pub/validator/directory.dart (right):

https://codereview.chromium.org/11741026/diff/1/utils/pub/validator/directory...
utils/pub/validator/directory.dart:33: 'tools.');
On 2013/01/03 23:18:54, Bob Nystrom wrote:
> How about:
> 
> ''Rename the top-level "$dir" directory to "$singularName".\n'
> 'This enables Dart scripts within that directory to use "package:" imports.'
> 
> Ditto for below. Better?

That doesn't really make sense for "doc", and I think a lot of people will have
non-Dart tool scripts. This will also be relevant if/when we list examples/docs
on pub.dartlang.org or add bin files to the users path. I feel like being a
little vague about the consequences makes sense here.

Expand Messages | Collapse Messages