Add a validator for top-level directory names.

utils/tests/pub/validator_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library validator_test;
 
 import 'dart:io';
 import 'dart:json';
 
 import 'test_pub.dart';
 import '../../../pkg/unittest/lib/unittest.dart';
 import '../../../pkg/http/lib/http.dart' as http;
 import '../../../pkg/http/lib/testing.dart';
 import '../../pub/entrypoint.dart';
 import '../../pub/io.dart';
 import '../../pub/validator.dart';
 import '../../pub/validator/dependency.dart';
+import '../../pub/validator/directory.dart';
 import '../../pub/validator/lib.dart';
 import '../../pub/validator/license.dart';
 import '../../pub/validator/name.dart';
 import '../../pub/validator/pubspec_field.dart';
 
 void expectNoValidationError(ValidatorCreator fn) {
   expectLater(schedulePackageValidation(fn), pairOf(isEmpty, isEmpty));
 }
 
 void expectValidationError(ValidatorCreator fn) {
   expectLater(schedulePackageValidation(fn), pairOf(isNot(isEmpty), anything));
 }
 
 void expectValidationWarning(ValidatorCreator fn) {
   expectLater(schedulePackageValidation(fn), pairOf(isEmpty, isNot(isEmpty)));
 }
 
 Validator dependency(Entrypoint entrypoint) =>
   new DependencyValidator(entrypoint);
 
+Validator directory(Entrypoint entrypoint) =>
+  new DirectoryValidator(entrypoint);
+
 Validator lib(Entrypoint entrypoint) => new LibValidator(entrypoint);
 
 Validator license(Entrypoint entrypoint) => new LicenseValidator(entrypoint);
 
 Validator name(Entrypoint entrypoint) => new NameValidator(entrypoint);
 
 Validator pubspecField(Entrypoint entrypoint) =>
   new PubspecFieldValidator(entrypoint);
 
 void scheduleNormalPackage() => normalPackage.scheduleCreate();
@@ skipping 66 matching lines @@
 
     test('has an unconstrained dependency on "unittest"', () {
       dir(appPath, [
         libPubspec("test_pkg", "1.0.0", [
           {'hosted': 'unittest'}
         ])
       ]).scheduleCreate();
       expectNoValidationError(dependency);
       run();
     });
+
+    test('has a nested directory named "tools"', () {
+      dir(appPath, [
+        dir("foo", [dir("tools")])
+      ]).scheduleCreate();
+      expectNoValidationError(directory);
+      run();
+    });
   });
 
   group('should consider a package invalid if it', () {
     setUp(scheduleNormalPackage);
 
     test('is missing the "homepage" field', () {
       var package = package("test_pkg", "1.0.0");
       package.remove("homepage");
       dir(appPath, [pubspec(package)]).scheduleCreate();
 
@@ skipping 402 matching lines @@
       dir(appPath, [
         libPubspec("test_pkg", "1.0.0", [
           {'hosted': {'name': 'test_pkg', 'version': '>=1.0.0'}}
         ])
       ]).scheduleCreate();
 
       expectValidationWarning(dependency);
 
       run();
     });
+
+    group('has a top-level directory named', () {
+      setUp(scheduleNormalPackage);
+
+      var names = ["tools", "tests", "docs", "examples", "sample", "samples"];
+      for (var name in names) {
+        test('"$name"', () {
+          dir(appPath, [dir(name)]).scheduleCreate();
+          expectValidationWarning(directory);
+          run();
+        });
+      }
+    });
   });
 }