dart2js cps: Clean up in type propagation.

dart2js cps: Clean up in type propagation.

Class names are no longer private. optimizers.dart whitelists the class
that needs to be exposed, so the privacy makes little difference.

Methods on AbstractValue that require access to the type system or
other "external thing" have been moved to ConstantPropagationLattice.
It should help readability and avoid parameter inflation when more
external things are suddenly needed to answer a query.

The UnitTypeSystem has been removed and TypeSystem has been merged
into TypeMaskSystem. The generic variable T has been removed as well.

BUG=
R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/953a6fd75f1e7bda462a4ffde1ffeef6117dc380

[asgerf, 2015-06-09 10:05:38]

asgerf@google.com changed reviewers:
+ karlklose@google.com, kmillikin@google.com

[asgerf, 2015-06-09 10:05:39]

https://codereview.chromium.org/1173563002/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right):

https://codereview.chromium.org/1173563002/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:283:
TypePropagator(dart2js.Compiler compiler)
It's not great to depend on Compiler here, but we sort of already did.

[Kevin Millikin (Google), 2015-06-09 10:30:53]

lgtm

https://codereview.chromium.org/1173563002/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right):

https://codereview.chromium.org/1173563002/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:168: if (value.isNothing)
return true;
I think value.isNothing || typeSystem.isDefinitelyBool(value.type) is somewhat
easier to read.

[asgerf, 2015-06-09 12:18:33]

https://codereview.chromium.org/1173563002/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right):

https://codereview.chromium.org/1173563002/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:168: if (value.isNothing)
return true;
On 2015/06/09 10:30:53, Kevin Millikin (Google) wrote:
> I think value.isNothing || typeSystem.isDefinitelyBool(value.type) is somewhat
> easier to read.

Done, although now it's not as consistent with isDefinitelyNotNull.

[asgerf, 2015-06-10 12:04:41]

Committed patchset #7 (id:120001) manually as
953a6fd75f1e7bda462a4ffde1ffeef6117dc380 (presubmit successful).