Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/task.dart

Issue 1173563002: dart2js cps: Clean up in type propagation. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: IntelliJ's autocompletion seems to make fun of me Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/task.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/task.dart b/pkg/compiler/lib/src/js_backend/codegen/task.dart
index 0540d4ca4a48d6121eb16c30bca2a0d0934f3144..01ec7a2282dcc15979263b85712b90da1b53f817 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/task.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/task.dart
@@ -39,8 +39,6 @@ class CpsFunctionCompiler implements FunctionCompiler {
final Glue glue;
final SourceInformationFactory sourceInformationFactory;
- TypeSystem types;
-
// TODO(karlklose,sigurm): remove and update dart-doc of [compile].
final FunctionCompiler fallbackCompiler;
@@ -64,7 +62,6 @@ class CpsFunctionCompiler implements FunctionCompiler {
/// features not implemented it will fall back to the ssa pipeline (for
/// platform code) or will cancel compilation (for user code).
js.Fun compile(CodegenWorkItem work) {
- types = new TypeMaskSystem(compiler);
AstElement element = work.element;
JavaScriptBackend backend = compiler.backend;
return compiler.withCurrentElement(element, () {
@@ -138,7 +135,7 @@ class CpsFunctionCompiler implements FunctionCompiler {
}
void dumpTypedIR(cps.FunctionDefinition cpsNode,
- TypePropagator<TypeMask> typePropagator) {
+ TypePropagator typePropagator) {
if (PRINT_TYPED_IR_FILTER != null &&
PRINT_TYPED_IR_FILTER.matchAsPrefix(cpsNode.element.name) != null) {
String printType(nodeOrRef, String s) {
@@ -166,11 +163,7 @@ class CpsFunctionCompiler implements FunctionCompiler {
assert(checkCpsIntegrity(cpsNode));
}
- TypePropagator typePropagator = new TypePropagator<TypeMask>(
- compiler.types,
- constantSystem,
- new TypeMaskSystem(compiler),
- compiler.internalError);
+ TypePropagator typePropagator = new TypePropagator(compiler);
applyCpsPass(typePropagator);
dumpTypedIR(cpsNode, typePropagator);
applyCpsPass(new RedundantPhiEliminator());
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/type_propagation.dart ('k') | tests/compiler/dart2js/analyze_unused_dart2js_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698