Issue 1173293007: Fix --verify_handles mode by properly checking for the static API handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1173293007: Fix --verify_handles mode by properly checking for the static API handles. (Closed)

Created:
5 years, 6 months ago by koda

Modified:
5 years, 6 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix --verify_handles mode by properly checking for the static API handles. This was an omission from 9a5dc19140022f5414fc68c4aef0a41dc0eb65a1. Also set this flag and --verify_on_transition in CustomIsolateTest to extend coverage. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/2789021e45dbf7ac4a84fffb42de9d4ff856e6f9

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -1 line)			Patch
M	runtime/vm/custom_isolate_test.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/dart.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/dart.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

koda

5 years, 6 months ago (2015-06-22 14:20:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2789021e45dbf7ac4a84fffb42de9d4ff856e6f9 (presubmit successful).