runtime/vm/dart_api_impl.cc - Issue 1173293007: Fix --verify_handles mode by properly checking for the static API handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 1173293007: Fix --verify_handles mode by properly checking for the static API handles. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/dart_api_impl.cc

diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc

index 89a22ce2977bad734f1d1fa0d2aa88f3e2f0d4e7..caea813fdc49012e6c05893b1e5641742720baf5 100644

--- a/runtime/vm/dart_api_impl.cc

+++ b/runtime/vm/dart_api_impl.cc

@@ -376,7 +376,7 @@ RawObject* Api::UnwrapHandle(Dart_Handle object) {

ASSERT(state != NULL);

ASSERT(!FLAG_verify_handles ||

state->IsValidLocalHandle(object) ||

- Dart::vm_isolate()->api_state()->IsValidLocalHandle(object));

+ Dart::IsReadOnlyApiHandle(object));

ASSERT(FinalizablePersistentHandle::raw_offset() == 0 &&

PersistentHandle::raw_offset() == 0 &&

LocalHandle::raw_offset() == 0);

« no previous file with comments | « runtime/vm/dart.cc ('k') | no next file » | no next file with comments »