Issue 11697007: Generate static factories with optional arguments.

Issue 11697007: Generate static factories with optional arguments. (Closed)

Created:
7 years, 12 months ago by Anton Muhin

Modified:
7 years, 11 months ago

Reviewers:
podivilov, sra1, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Generate static factories with optional arguments. R=blois@google.com,podivilov@chromium.org,sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=16568

Patch Set 1 #

Total comments: 2

Created: 7 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -112 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	9 chunks	+40 lines, -39 lines	2 comments	Download
M	sdk/lib/html/scripts/htmldartgenerator.py	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	sdk/lib/html/scripts/systemhtml.py	View	1 chunk	+39 lines, -13 lines	0 comments	Download
D	sdk/lib/html/templates/html/dart2js/factoryprovider_DataView.darttemplate	View	1 chunk	+0 lines, -9 lines	0 comments	Download
D	sdk/lib/html/templates/html/dart2js/factoryprovider_FormData.darttemplate	View	1 chunk	+0 lines, -4 lines	0 comments	Download
D	sdk/lib/html/templates/html/dart2js/factoryprovider_HTMLAudioElement.darttemplate	View	1 chunk	+0 lines, -4 lines	0 comments	Download
D	sdk/lib/html/templates/html/dart2js/factoryprovider_HTMLOptionElement.darttemplate	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	sdk/lib/html/templates/html/dart2js/factoryprovider_SharedWorker.darttemplate	View	1 chunk	+0 lines, -4 lines	0 comments	Download
D	sdk/lib/html/templates/html/dart2js/factoryprovider_TextTrackCue.darttemplate	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	sdk/lib/html/templates/html/dart2js/factoryprovider_WebKitCSSMatrix.darttemplate	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	sdk/lib/html/templates/html/impl/factoryprovider_Elements.darttemplate	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

podivilov

lgtm https://codereview.chromium.org/11697007/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (left): https://codereview.chromium.org/11697007/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#oldcode17209 sdk/lib/html/dart2js/html_dart2js.dart:17209: [String settings, bool pauseOnExit]) { Were these optional ...

7 years, 11 months ago (2012-12-29 07:42:49 UTC) #2

Anton Muhin

7 years, 11 months ago (2012-12-29 08:32:07 UTC) #3

Thanks a lot for review, Pasha, submitting.

Pete, Stephen, I'd be happy to address your comments in a separate CL.

https://codereview.chromium.org/11697007/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (left):

https://codereview.chromium.org/11697007/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:17209: [String settings, bool
pauseOnExit]) {
On 2012/12/29 07:42:49, podivilov wrote:
> Were these optional arguments used anywhere?

I do not have a slightest idea

Expand Messages | Collapse Messages