Generate static factories with optional arguments.

sdk/lib/html/scripts/htmldartgenerator.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for the system to generate
 dart:html APIs from the IDL database."""
 
 from generator import AnalyzeOperation, ConstantOutputOrder, \
     DartDomNameOfAttribute, FindMatchingAttribute, IsDartCollectionType, \
@@ skipping 256 matching lines @@
             PARAMS=constructor_info.ParametersDeclaration(self._DartType),
             FACTORY=factory_name,
             FACTORY_PARAMS=constructor_info.ParametersAsArgumentList())
 
         for index, param_info in enumerate(constructor_info.param_infos):
           if param_info.is_optional:
             dispatcher_emitter.Emit(
               '    if (!?$OPT_PARAM_NAME) {\n'
               '      return $FACTORY._create($FACTORY_PARAMS);\n'
               '    }\n',
-              OPT_PARAM_NAME=constructor_info.param_infos[index].name,
+              OPT_PARAM_NAME=param_info.name,
               FACTORY=factory_name,
               FACTORY_PARAMS=constructor_info.ParametersAsArgumentList(index))
       else:
         inits = self._members_emitter.Emit(
             '\n'
             '  factory $CONSTRUCTOR($PARAMS) {\n'
             '    var e = $FACTORY.$CTOR_FACTORY_NAME($FACTORY_PARAMS);\n'
             '$!INITS'
             '    return e;\n'
             '  }\n',
             CONSTRUCTOR=constructor_info._ConstructorFullName(self._DartType),
             FACTORY=factory_name,
             CTOR_FACTORY_NAME=factory_constructor_name,
             PARAMS=constructor_info.ParametersDeclaration(self._DartType),
             FACTORY_PARAMS=factory_parameters)
 
         for index, param_info in enumerate(constructor_info.param_infos):
           if param_info.is_optional:
-            inits.Emit('    if ($E != null) e.$E = $E;\n',
-                E=constructor_info.param_infos[index].name)
+            inits.Emit('    if ($E != null) e.$E = $E;\n', E=param_info.name)
 
     if not constructor_info.pure_dart_constructor:
       template_file = ('factoryprovider_%s.darttemplate' % self._interface.doc_js_name)
       template = self._template_loader.TryLoad(template_file)
       if template:
         # There is a class specific factory.
         # TODO(antonm): should move into the class template.
         self._members_emitter.Emit(template)
       else:
         self.EmitStaticFactory(constructor_info)
@@ skipping 101 matching lines @@
         walk(interface.parents)
       else:
         walk(interface.parents[1:])
     return result
 
   def _DartType(self, type_name):
     return self._type_registry.DartType(type_name)
 
   def _IsPrivate(self, name):
     return name.startswith('_')