Issue 11696005: Improve line info accuracy in debugging

Issue 11696005: Improve line info accuracy in debugging (Closed)

Created:
7 years, 12 months ago by hausner

Modified:
7 years, 11 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Improve line info accuracy in debugging Committed: https://code.google.com/p/dart/source/detail?r=16550

Patch Set 2 : #

Created: 7 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -106 lines)			Patch
M	runtime/vm/debugger.cc	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/debugger_api_impl_test.cc	View	1	1 chunk	+11 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/intrinsifier.h	View	1	2 chunks	+50 lines, -50 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	2 chunks	+9 lines, -2 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	13 chunks	+41 lines, -41 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comments. -Ivan https://codereview.chromium.org/11696005/diff/1/runtime/vm/debugger_api_impl_test.cc File runtime/vm/debugger_api_impl_test.cc (right): https://codereview.chromium.org/11696005/diff/1/runtime/vm/debugger_api_impl_test.cc#newcode980 runtime/vm/debugger_api_impl_test.cc:980: func = test_lib.LookupFunctionInSource(script_url, 3); Shouldn't ...

7 years, 12 months ago (2012-12-28 17:53:49 UTC) #2

hausner

7 years, 11 months ago (2013-01-07 23:24:31 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/11696005/diff/1/runtime/vm/debugger_api_impl_...
File runtime/vm/debugger_api_impl_test.cc (right):

https://codereview.chromium.org/11696005/diff/1/runtime/vm/debugger_api_impl_...
runtime/vm/debugger_api_impl_test.cc:980: func =
test_lib.LookupFunctionInSource(script_url, 3);
On 2012/12/28 17:53:49, Ivan Posva wrote:
> Shouldn't this be lines 2,3 and 4 now?

Done.

https://codereview.chromium.org/11696005/diff/1/runtime/vm/debugger_api_impl_...
runtime/vm/debugger_api_impl_test.cc:985: EXPECT(!func.IsNull());
On 2012/12/28 17:53:49, Ivan Posva wrote:
> Please explain in a comment why you find the constructor for A.

Done.

https://codereview.chromium.org/11696005/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/11696005/diff/1/runtime/vm/object.cc#newcode5671
runtime/vm/object.cc:5671: func = LookupFunctionInScript(script,
first_token_pos);
On 2012/12/28 17:53:49, Ivan Posva wrote:
> How about this?
> for (intptr_t token_pos = first_token_pos; token_pos <= last_token_pos;
> token_pos++) {
>   func = LookupFunctionInScript(script, token_pos);
>   if (!func.IsNull()) {
>     return func.raw();
>   }
> }
> return func.raw();
> 
> This way you get the first function found on the line, in case there are
> multiple functions.

Done.

Expand Messages | Collapse Messages