Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1166743005: Remove GetSVNRevision from tools/utils.py (Closed)

Created:
5 years, 6 months ago by ricow1
Modified:
5 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove GetSVNRevision from tools/utils.py Also change all callsites to use git. I have a pending request to Vijay for info on what tools/dartium/deploy_aar.py is for. BUG= R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/74759d5771f9d27ed8f53c356d3134a147fcdbef

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -43 lines) Patch
M tools/bots/dart_sdk.py View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/bots/dartium_android.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/bots/linux_distribution_support.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/create_sdk.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/create_tarball.py View 2 chunks +6 lines, -6 lines 0 comments Download
M tools/dartium/buildbot_annotated_steps.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/utils.py View 1 5 chunks +10 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ricow1
5 years, 6 months ago (2015-06-08 12:31:22 UTC) #2
Bill Hesse
lgtm https://codereview.chromium.org/1166743005/diff/1/tools/utils.py File tools/utils.py (right): https://codereview.chromium.org/1166743005/diff/1/tools/utils.py#newcode402 tools/utils.py:402: # To eliminate clashing with older archived builds ...
5 years, 6 months ago (2015-06-08 12:42:42 UTC) #3
ricow1
https://codereview.chromium.org/1166743005/diff/1/tools/utils.py File tools/utils.py (right): https://codereview.chromium.org/1166743005/diff/1/tools/utils.py#newcode402 tools/utils.py:402: # To eliminate clashing with older archived builds on ...
5 years, 6 months ago (2015-06-08 12:55:51 UTC) #4
ricow1
Committed patchset #2 (id:20001) manually as 74759d5771f9d27ed8f53c356d3134a147fcdbef (presubmit successful).
5 years, 6 months ago (2015-06-08 12:57:04 UTC) #5
Søren Gjesse
5 years, 6 months ago (2015-06-10 12:56:18 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698