Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: tools/dartium/buildbot_annotated_steps.py

Issue 1166743005: Remove GetSVNRevision from tools/utils.py (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/create_tarball.py ('k') | tools/utils.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 2
3 # Copyright (c) 2014 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2014 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 """Dartium buildbot steps 7 """Dartium buildbot steps
8 8
9 Archive dartium, content_shell, and chromedriver to the cloud storage bucket 9 Archive dartium, content_shell, and chromedriver to the cloud storage bucket
10 gs://dart-archive, and run tests, including the Dart layout tests. 10 gs://dart-archive, and run tests, including the Dart layout tests.
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 info.version, 72 info.version,
73 component, checked) 73 component, checked)
74 return status 74 return status
75 75
76 76
77 def main(): 77 def main():
78 # We need to chdir() to src/dart in order to get the correct revision number. 78 # We need to chdir() to src/dart in order to get the correct revision number.
79 with utils.ChangedWorkingDirectory(DART_PATH): 79 with utils.ChangedWorkingDirectory(DART_PATH):
80 dart_tools_utils = imp.load_source('dart_tools_utils', 80 dart_tools_utils = imp.load_source('dart_tools_utils',
81 os.path.join('tools', 'utils.py')) 81 os.path.join('tools', 'utils.py'))
82 dart_revision = dart_tools_utils.GetSVNRevision() 82 dart_revision = dart_tools_utils.GetArchiveVersion()
83 83
84 version = '%s.0' % dart_revision 84 version = '%s.0' % dart_revision
85 info = upload_steps.BuildInfo(dart_revision, version) 85 info = upload_steps.BuildInfo(dart_revision, version)
86 86
87 result = 0 87 result = 0
88 88
89 # Archive to the revision bucket unless integration build 89 # Archive to the revision bucket unless integration build
90 if info.channel != 'integration': 90 if info.channel != 'integration':
91 result = upload_steps.ArchiveAndUpload(info, archive_latest=False) 91 result = upload_steps.ArchiveAndUpload(info, archive_latest=False)
92 # On dev/stable we archive to the latest bucket as well 92 # On dev/stable we archive to the latest bucket as well
(...skipping 20 matching lines...) Expand all
113 test_filter=DRT_FILTER) or result 113 test_filter=DRT_FILTER) or result
114 result = Test(info, 'drt', 'core', 'checked') or result 114 result = Test(info, 'drt', 'core', 'checked') or result
115 115
116 # On the 'be' channel, we only archive to the latest bucket if all tests were 116 # On the 'be' channel, we only archive to the latest bucket if all tests were
117 # successful. 117 # successful.
118 if result == 0 and info.channel == 'be': 118 if result == 0 and info.channel == 'be':
119 result = upload_steps.ArchiveAndUpload(info, archive_latest=True) or result 119 result = upload_steps.ArchiveAndUpload(info, archive_latest=True) or result
120 120
121 if __name__ == '__main__': 121 if __name__ == '__main__':
122 sys.exit(main()) 122 sys.exit(main())
OLDNEW
« no previous file with comments | « tools/create_tarball.py ('k') | tools/utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698