Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 1166723002: Add StringLengthConstantExpression (Closed)

Created:
5 years, 6 months ago by Johnni Winther
Modified:
5 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add StringLengthConstantExpression ... and make .fromEnvironment name a ConstantExpression. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/3250c8fd910794190f56950d6986cf2dccfaa34e

Patch Set 1 #

Patch Set 2 : Fix tests. #

Patch Set 3 : Rebased #

Patch Set 4 : Update .fromEnvironment test expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -42 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 2 chunks +10 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 1 17 chunks +139 lines, -22 lines 0 comments Download
M pkg/docgen/lib/src/models/model_helpers.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/constant_expression_evaluate_test.dart View 1 4 chunks +6 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/constant_expression_test.dart View 1 3 chunks +4 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_data.dart View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 6 months ago (2015-06-02 07:01:54 UTC) #2
karlklose
LGTM.
5 years, 6 months ago (2015-06-02 08:31:10 UTC) #3
Johnni Winther
5 years, 6 months ago (2015-06-02 08:53:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
3250c8fd910794190f56950d6986cf2dccfaa34e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698