Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: tests/compiler/dart2js/constant_expression_test.dart

Issue 1166723002: Add StringLengthConstantExpression (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Update .fromEnvironment test expectations. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/constant_expression_test.dart
diff --git a/tests/compiler/dart2js/constant_expression_test.dart b/tests/compiler/dart2js/constant_expression_test.dart
index c7fdaaf3ea72bbcbc3c231690e20ccce9a5d65e3..d4e9df03aeac8ee3cc6dbbf560dfe1eb8cdd538e 100644
--- a/tests/compiler/dart2js/constant_expression_test.dart
+++ b/tests/compiler/dart2js/constant_expression_test.dart
@@ -52,6 +52,7 @@ const List<TestData> DATA = const [
const ConstantData('"foo"', ConstantExpressionKind.STRING),
const ConstantData('1 + 2', ConstantExpressionKind.BINARY),
const ConstantData('-(1)', ConstantExpressionKind.UNARY, text: '-1'),
+ const ConstantData('"foo".length', ConstantExpressionKind.STRING_LENGTH),
const ConstantData('identical(0, 1)', ConstantExpressionKind.IDENTICAL),
const ConstantData('"a" "b"', ConstantExpressionKind.CONCATENATE,
text: '"ab"'),
@@ -148,7 +149,7 @@ class B<S> implements C {
const factory B({field1}) = A<B<S>>;
// TODO(johnniwinther): Enable this when the constructor evaluator doesn't
// crash:
- /*const factory B.named() = A<S>;*/
+ const factory B.named() = A<S>;
}
class C<U> {
const factory C({field1}) = A<B<double>>;
@@ -183,14 +184,12 @@ class C<U> {
fields: const {
'field(A#field1)': '87',
}),
- // TODO(johnniwinther): Enable this when the constructor evaluator doesn't
- // crash:
- /*const ConstantData('const B<int>.named()',
+ const ConstantData('const B<int>.named()',
ConstantExpressionKind.CONSTRUCTED,
type: 'A<int>',
fields: const {
'field(A#field1)': '42',
- }),*/
+ }),
]),
];

Powered by Google App Engine
This is Rietveld 408576698