Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1166433008: 2nd attempt at adding streamListen/streamCancel to the service protocol. (Closed)

Created:
5 years, 6 months ago by turnidge
Modified:
5 years, 6 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

2nd attempt at adding streamListen/streamCancel to the service protocol. This time I am committing the protocol changes first and saving the Observatory changes for a second cl. ------ We currently support 5 streams: Isolate, Debug, GC, _Echo, and _Graph. Only generate events when at least one client is listening to the corresponding event stream. Only send events to the clients that actually request them. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/996f01270734fb72dc12e42c8a0ee0293dc13006

Patch Set 1 #

Patch Set 2 : cleanups before review #

Total comments: 2

Patch Set 3 : code review #

Patch Set 4 : fix context objects #

Unified diffs Side-by-side diffs Delta from patch set Stats (+414 lines, -115 lines) Patch
M runtime/bin/main.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/server.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/include/dart_api.h View 1 chunk +14 lines, -13 lines 0 comments Download
M runtime/observatory/lib/src/elements/context_view.html View 1 2 3 2 chunks +8 lines, -6 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_ref.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 2 chunks +24 lines, -5 lines 0 comments Download
M runtime/observatory/tests/service/contexts_test.dart View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/debugger.cc View 4 chunks +29 lines, -5 lines 0 comments Download
M runtime/vm/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +14 lines, -10 lines 0 comments Download
M runtime/vm/json_stream.h View 1 2 chunks +10 lines, -4 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/service.h View 2 chunks +21 lines, -5 lines 0 comments Download
M runtime/vm/service.cc View 12 chunks +88 lines, -24 lines 0 comments Download
M runtime/vm/service/client.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/service/message.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M runtime/vm/service/service.md View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/service/vmservice.dart View 1 2 9 chunks +126 lines, -26 lines 0 comments Download
M runtime/vm/service_event.h View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/service_event.cc View 1 2 2 chunks +31 lines, -0 lines 0 comments Download
M runtime/vm/service_isolate.cc View 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
turnidge
5 years, 6 months ago (2015-06-04 06:31:35 UTC) #2
Cutch
lgtm https://codereview.chromium.org/1166433008/diff/20001/runtime/vm/service/vmservice.dart File runtime/vm/service/vmservice.dart (right): https://codereview.chromium.org/1166433008/diff/20001/runtime/vm/service/vmservice.dart#newcode182 runtime/vm/service/vmservice.dart:182: var validStreams = [ 'Isolate', 'Debug', 'GC', '_Echo', ...
5 years, 6 months ago (2015-06-04 13:25:14 UTC) #3
turnidge
https://codereview.chromium.org/1166433008/diff/20001/runtime/vm/service/vmservice.dart File runtime/vm/service/vmservice.dart (right): https://codereview.chromium.org/1166433008/diff/20001/runtime/vm/service/vmservice.dart#newcode182 runtime/vm/service/vmservice.dart:182: var validStreams = [ 'Isolate', 'Debug', 'GC', '_Echo', '_Graph' ...
5 years, 6 months ago (2015-06-04 16:18:44 UTC) #4
turnidge
5 years, 6 months ago (2015-06-04 16:57:28 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
996f01270734fb72dc12e42c8a0ee0293dc13006 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698