Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: runtime/vm/isolate.cc

Issue 1166433008: 2nd attempt at adding streamListen/streamCancel to the service protocol. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: fix context objects Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/heap.cc ('k') | runtime/vm/json_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index e526d446cd92f969cac4a13e20dfe512b22b9a70..40159cf9d80a7ddcdc6b3e1e0f3850e803d53236 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -450,20 +450,24 @@ bool IsolateMessageHandler::HandleMessage(Message* message) {
void IsolateMessageHandler::NotifyPauseOnStart() {
- StartIsolateScope start_isolate(isolate());
- StackZone zone(I);
- HandleScope handle_scope(I);
- ServiceEvent pause_event(isolate(), ServiceEvent::kPauseStart);
- Service::HandleEvent(&pause_event);
+ if (Service::NeedsDebugEvents()) {
+ StartIsolateScope start_isolate(isolate());
+ StackZone zone(I);
+ HandleScope handle_scope(I);
+ ServiceEvent pause_event(isolate(), ServiceEvent::kPauseStart);
+ Service::HandleEvent(&pause_event);
+ }
}
void IsolateMessageHandler::NotifyPauseOnExit() {
- StartIsolateScope start_isolate(isolate());
- StackZone zone(I);
- HandleScope handle_scope(I);
- ServiceEvent pause_event(isolate(), ServiceEvent::kPauseExit);
- Service::HandleEvent(&pause_event);
+ if (Service::NeedsDebugEvents()) {
+ StartIsolateScope start_isolate(isolate());
+ StackZone zone(I);
+ HandleScope handle_scope(I);
+ ServiceEvent pause_event(isolate(), ServiceEvent::kPauseExit);
+ Service::HandleEvent(&pause_event);
+ }
}
« no previous file with comments | « runtime/vm/heap.cc ('k') | runtime/vm/json_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698